| Message ID | 1476947569-23552-1-git-send-email-yamada.masahiro@socionext.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On 20-10-16, 16:12, Masahiro Yamada wrote: > These log messages are wrong because _of_get_opp_desc_node() returns > an operating-points-v2 node. > > Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed > static checker warnings, and reworded the messages at the same time > (but the latter was not mentioned in the git-log). > > Restore the correct messages. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Changes in v3: > - Revive __func__ > > Changes in v2: > - Reword git-log slightly > comments -> log messages Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On 10/20, Masahiro Yamada wrote: > These log messages are wrong because _of_get_opp_desc_node() returns > an operating-points-v2 node. > > Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed > static checker warnings, and reworded the messages at the same time > (but the latter was not mentioned in the git-log). > > Restore the correct messages. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
On Thursday, October 20, 2016 12:18:58 PM Stephen Boyd wrote: > On 10/20, Masahiro Yamada wrote: > > These log messages are wrong because _of_get_opp_desc_node() returns > > an operating-points-v2 node. > > > > Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed > > static checker warnings, and reworded the messages at the same time > > (but the latter was not mentioned in the git-log). > > > > Restore the correct messages. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> Applied. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/base/power/opp/of.c b/drivers/base/power/opp/of.c index 6480137..5b3755e 100644 --- a/drivers/base/power/opp/of.c +++ b/drivers/base/power/opp/of.c @@ -562,7 +562,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, /* Get OPP descriptor node */ np = _of_get_opp_desc_node(cpu_dev); if (!np) { - dev_dbg(cpu_dev, "%s: Couldn't find cpu_dev node.\n", __func__); + dev_dbg(cpu_dev, "%s: Couldn't find opp node.\n", __func__); return -ENOENT; } @@ -587,7 +587,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, /* Get OPP descriptor node */ tmp_np = _of_get_opp_desc_node(tcpu_dev); if (!tmp_np) { - dev_err(tcpu_dev, "%s: Couldn't find tcpu_dev node.\n", + dev_err(tcpu_dev, "%s: Couldn't find opp node.\n", __func__); ret = -ENOENT; goto put_cpu_node;
These log messages are wrong because _of_get_opp_desc_node() returns an operating-points-v2 node. Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed static checker warnings, and reworded the messages at the same time (but the latter was not mentioned in the git-log). Restore the correct messages. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Changes in v3: - Revive __func__ Changes in v2: - Reword git-log slightly comments -> log messages drivers/base/power/opp/of.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)