From patchwork Wed Mar 27 04:59:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 10872499 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 95766186E for ; Wed, 27 Mar 2019 04:59:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8074828D32 for ; Wed, 27 Mar 2019 04:59:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 73E2928D35; Wed, 27 Mar 2019 04:59:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2246028D33 for ; Wed, 27 Mar 2019 04:59:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725730AbfC0E6z (ORCPT ); Wed, 27 Mar 2019 00:58:55 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:36622 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725613AbfC0E6z (ORCPT ); Wed, 27 Mar 2019 00:58:55 -0400 Received: by mail-pl1-f194.google.com with SMTP id k2so2721881plt.3; Tue, 26 Mar 2019 21:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tvDsEaR5RVMjQmpl7pvXE6aMRh7V9pplB1t4MlLyGlo=; b=ttJmL44tLwmeymwJk21YO5pD2dbq91CaeW1b2AyPJi9Sl5J2FnhLhAjxGI07JVZ0ev GAUnoTmThB2nh0kOiZNRgIRXh9sUjgXjGLE7RRHXP0MLUC4EkXkBDSstM64EDRJ6YqqS TFtKVyWQCYL3irrd6qYAZs8JbDNwm/qw8n6UdWxC1aXCjf3zpnvbubMqR2FvGESakekj DvJserniuhIzf91JoYxCeyLD6opMp7lemdpPjpAoADet3HJvymtnIIY27MJF92IUjXTS +uRkEYqZ4T84bPPnrXA36HLVVVOxcGIV7XMwEe8Gpsx1FuSe0yq4UCs9g1kDr15iuSUs uz0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tvDsEaR5RVMjQmpl7pvXE6aMRh7V9pplB1t4MlLyGlo=; b=p9XmdMyNM8V+wc8t340fA27pcPiYp26slEDfSumiWxq0ZWtT3u66De4tWpKG/O96kG CZtqLPU6OTrm1p5k1pfKuAUJ8oros1NBfLPpo6nzFHxY5dHyROAWEURL+zth2uVCe0K+ rNo2e8UAtMogOrUeEOKZbBRWk5XokDxSkwI2ewfBUtzIZIVQOkQ0yaKQva8jEKzVxzEZ CWL4GdSB/bop8dmspcarDtHcyB2qbkUkm1s/pi1SkjEAR3wAtJmdvZamBYpBFSAbeZ9j Wg0IJmR1VYEzRg2td2A4EzdfGw1to4V5b6V/dL7I39Y4TKnkDg4dL/s0g0DuPot72oUw kbdw== X-Gm-Message-State: APjAAAVsJ47pMz/H7Fu2zZi5uv+2WYIuXTXvf4yEZJkXV9g2ON6Ul1Qe VkXEmdUKhIHXhBvQlQ6pRJU= X-Google-Smtp-Source: APXvYqyqCK2pgNbDSWh5tfKVfkD1OLh24THmdaZzxauSeDG2Mm7+3YUTDtyZf8C5ZYbDUHkhAAYEqw== X-Received: by 2002:a17:902:988e:: with SMTP id s14mr22560082plp.167.1553662734795; Tue, 26 Mar 2019 21:58:54 -0700 (PDT) Received: from localhost.localdomain ([2001:268:c0a5:6014:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id l19sm877015pff.1.2019.03.26.21.58.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 21:58:54 -0700 (PDT) From: William Breathitt Gray To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: akpm@linux-foundation.org, linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, yamada.masahiro@socionext.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, geert@linux-m68k.org, preid@electromag.com.au, William Breathitt Gray Subject: [PATCH v13 04/11] gpio: 104-idi-48: Utilize for_each_set_clump8 macro Date: Wed, 27 Mar 2019 13:59:50 +0900 Message-Id: <1476995eb0bf988b4a3cc27f0e5e1484933d93ec.1553661964.git.vilhelm.gray@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-idi-48.c | 36 +++++++--------------------------- 1 file changed, 7 insertions(+), 29 deletions(-) diff --git a/drivers/gpio/gpio-104-idi-48.c b/drivers/gpio/gpio-104-idi-48.c index 88dc6f2449f6..9b43964b0412 100644 --- a/drivers/gpio/gpio-104-idi-48.c +++ b/drivers/gpio/gpio-104-idi-48.c @@ -93,42 +93,20 @@ static int idi_48_gpio_get_multiple(struct gpio_chip *chip, unsigned long *mask, unsigned long *bits) { struct idi_48_gpio *const idi48gpio = gpiochip_get_data(chip); - size_t i; + unsigned long offset; + unsigned long gpio_mask; static const size_t ports[] = { 0, 1, 2, 4, 5, 6 }; - const unsigned int gpio_reg_size = 8; - unsigned int bits_offset; - size_t word_index; - unsigned int word_offset; - unsigned long word_mask; - const unsigned long port_mask = GENMASK(gpio_reg_size - 1, 0); + unsigned int port_addr; unsigned long port_state; /* clear bits array to a clean slate */ bitmap_zero(bits, chip->ngpio); - /* get bits are evaluated a gpio port register at a time */ - for (i = 0; i < ARRAY_SIZE(ports); i++) { - /* gpio offset in bits array */ - bits_offset = i * gpio_reg_size; + for_each_set_clump8(offset, gpio_mask, mask, ARRAY_SIZE(ports) * 8) { + port_addr = idi48gpio->base + ports[offset / 8]; + port_state = inb(port_addr) & gpio_mask; - /* word index for bits array */ - word_index = BIT_WORD(bits_offset); - - /* gpio offset within current word of bits array */ - word_offset = bits_offset % BITS_PER_LONG; - - /* mask of get bits for current gpio within current word */ - word_mask = mask[word_index] & (port_mask << word_offset); - if (!word_mask) { - /* no get bits in this port so skip to next one */ - continue; - } - - /* read bits from current gpio port */ - port_state = inb(idi48gpio->base + ports[i]); - - /* store acquired bits at respective bits array offset */ - bits[word_index] |= (port_state << word_offset) & word_mask; + bitmap_set_value8(bits, port_state, offset); } return 0;