From patchwork Fri Nov 18 23:52:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 9437693 X-Patchwork-Delegate: rui.zhang@intel.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4344360237 for ; Sat, 19 Nov 2016 00:00:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3127129A60 for ; Sat, 19 Nov 2016 00:00:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2356229A64; Sat, 19 Nov 2016 00:00:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6E2A29A60 for ; Sat, 19 Nov 2016 00:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753004AbcKSAAk (ORCPT ); Fri, 18 Nov 2016 19:00:40 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:36374 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752363AbcKSAAj (ORCPT ); Fri, 18 Nov 2016 19:00:39 -0500 Received: by mail-pf0-f171.google.com with SMTP id 189so56686828pfz.3 for ; Fri, 18 Nov 2016 16:00:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9kMkrSkvWM7QGbdRwhTQQpqGU/GzV4cxs0SB/0laE5I=; b=RTj7ckMr8mO5FMnGoV7pgHPky3IUBjWO6kNA4mPAW6UoCzYnWmjuNOZSAlIEtOmpJj KHGtgEJbi6Q77HKsBvkRxqCCWHWOYq999M25bjTKikbfCQHP0yRtFNFRIm9bF38FOAEY 6qp/Kc5LL6kmWea1R/LOASyhzMgSjrCsYHXDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9kMkrSkvWM7QGbdRwhTQQpqGU/GzV4cxs0SB/0laE5I=; b=SydM9C86ZtlVwSyYReeNQmnLycSAOV63RbxGFgQHPM2ZH/MhQ+S4Nsmrf2XYwYihcP Rhy7DAuO/QsPLirm9m0HFG1Gq1FBu058JA42IUBt1vwHetgpdhbqbjbRgeSez9mbdZwL 9SZ25MNK/KauXpc6u8cIxbOFGTP435b5IFAH3YharqSlGC13kUe2pj+CdCuEWwgAxlns SjO4PjGRK6keAdQRrvHFuIQ83BKtcIKYKoJMSjFV4oKM4R9YjtUGFfe7aMDbiUGszIyS jU3YX/hcveZhA+rnSfsYSu8WEXgJo5ZLwCBtj6e2jNHAAOVy2kaipoINExMFRw3dNtjI 5Lsw== X-Gm-Message-State: AKaTC03S2J9hjbsxFGnlvfrYNMs6ElNNPeI6boJa+fy32EJpE1wFRDpVU4xzxhPSdP6JAfrB X-Received: by 10.99.44.84 with SMTP id s81mr4634233pgs.153.1479513182064; Fri, 18 Nov 2016 15:53:02 -0800 (PST) Received: from ban.mtv.corp.google.com ([172.22.64.120]) by smtp.gmail.com with ESMTPSA id t21sm20428247pfa.1.2016.11.18.15.53.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 18 Nov 2016 15:53:01 -0800 (PST) From: Brian Norris To: Zhang Rui , Eduardo Valentin Cc: Heiko Stuebner , linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Caesar Wang , Stephen Barber , Brian Norris Subject: [PATCH 2/3] thermal: rockchip: improve conversion error messages Date: Fri, 18 Nov 2016 15:52:56 -0800 Message-Id: <1479513177-81504-2-git-send-email-briannorris@chromium.org> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 In-Reply-To: <1479513177-81504-1-git-send-email-briannorris@chromium.org> References: <1479513177-81504-1-git-send-email-briannorris@chromium.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid temperature was being requested when conversion fails. It's also good to return an error when we can't handle a conversion properly. While we're at it, fix the grammar too. Signed-off-by: Brian Norris Reviewed-by: Caesar Wang@rock-chips.com --- Note: it'd probably be even nicer to know which sensor this was, but we've kinda abstracted that one away by this point... drivers/thermal/rockchip_thermal.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index e227a9f0acf7..35554d146b9d 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -424,7 +424,8 @@ static u32 rk_tsadcv2_temp_to_code(struct chip_tsadc_table table, } exit: - pr_err("Invalid the conversion, error=%d\n", error); + pr_err("%s: invalid temperature, temp=%d error=%d\n", + __func__, temp, error); return error; } @@ -475,7 +476,9 @@ static int rk_tsadcv2_code_to_temp(struct chip_tsadc_table table, u32 code, } break; default: - pr_err("Invalid the conversion table\n"); + pr_err("%s: invalid conversion table, mode=%d\n", + __func__, table.mode); + return -EINVAL; } /*