From patchwork Mon Dec 12 11:05:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 9470441 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1927660573 for ; Mon, 12 Dec 2016 11:07:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0862528399 for ; Mon, 12 Dec 2016 11:07:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED38028473; Mon, 12 Dec 2016 11:07:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C4092845A for ; Mon, 12 Dec 2016 11:07:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751266AbcLLLGB (ORCPT ); Mon, 12 Dec 2016 06:06:01 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36119 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932181AbcLLLF7 (ORCPT ); Mon, 12 Dec 2016 06:05:59 -0500 Received: by mail-pf0-f193.google.com with SMTP id c4so4270256pfb.3; Mon, 12 Dec 2016 03:05:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ezutMjq6u7Xtm2UNpEHFz1+aXDTmYPrGtxB3xQp9zss=; b=YPyMJBU1tI+3Wd43GWDpB0td9lxrLe6t6Xtn2HRg1sRZp9rmrhISjOjO8NXxQxdMnP 0lMrvCbjP32v+NmRA+N8/X5aRlnCzlOe/Nrf6zDvC8h7SQkpHkSnnMdCPOXge7S5H2bI 7+r4MQi1KGRbMNrLFyrADyqHtoLWZCpgEbteyyTsL8WtkI8rcZBzFuwKunKSUBv1QO9X L34HMBj+A/BIhhwq5zq6vDqOVOz7UsvSWQo3jW2ZO8B9t9auSOz3C9TZdgPqj3ybPpEn cDUWQzXIXH0jX4zWLAxi9O1B+HZHtrIxqkeRchHHMjlgA+haKaQrkNIthCNaexaS74a7 etDg== X-Gm-Message-State: AKaTC02ue9FyzXlx8Mzfi8Az7UNHck0LujdqB0eO8jCbtMeMdcfhMRuanv92tSU4eEV7Xg== X-Received: by 10.99.229.17 with SMTP id r17mr166730749pgh.149.1481540759038; Mon, 12 Dec 2016 03:05:59 -0800 (PST) Received: from localhost.localdomain ([47.89.33.70]) by smtp.gmail.com with ESMTPSA id i124sm76047411pgd.15.2016.12.12.03.05.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Dec 2016 03:05:58 -0800 (PST) From: Caesar Wang To: edubezval@gmail.com, rui.zhang@intel.com Cc: linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org, briannorris@chromium.org, linux-kernel@vger.kernel.org, smbarber@chromium.org, Caesar Wang Subject: [PATCH v4 1/5] thermal: rockchip: improve conversion error messages Date: Mon, 12 Dec 2016 19:05:31 +0800 Message-Id: <1481540735-12710-2-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1481540735-12710-1-git-send-email-wxt@rock-chips.com> References: <1481540735-12710-1-git-send-email-wxt@rock-chips.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Brian Norris These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid temperature was being requested when conversion fails. It's also good to return an error when we can't handle a conversion properly. While we're at it, fix the grammar too. Signed-off-by: Brian Norris Signed-off-by: Caesar Wang --- Changes in v4: - As Eduardo and Brian commnets on https://patchwork.kernel.org/patch/9449301 Changes in v3: None Changes in v2: None Changes in v1: - The original Brian posted on https://patchwork.kernel.org/patch/9437686 Note: it'd probably be even nicer to know which sensor this was, but we've kinda abstracted that one away by this point... drivers/thermal/rockchip_thermal.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index b811b0f..3bbc97c 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -424,7 +424,8 @@ static u32 rk_tsadcv2_temp_to_code(struct chip_tsadc_table table, } exit: - pr_err("Invalid the conversion, error=%d\n", error); + pr_err("%s: invalid temperature, temp=%d error=%d\n", + __func__, temp, error); return error; } @@ -475,7 +476,8 @@ static int rk_tsadcv2_code_to_temp(struct chip_tsadc_table table, u32 code, } break; default: - pr_err("Invalid the conversion table\n"); + pr_err("%s: unknown table mode: %d\n", __func__, table.mode); + return -EINVAL; } /*