diff mbox

[v2,3/8] ARM: OMAP5: Thermal: Add slope and offset values

Message ID 1489046762-11288-4-git-send-email-j-keerthy@ti.com
State Accepted
Delegated to: Eduardo Valentin
Headers show

Commit Message

J, KEERTHY March 9, 2017, 8:05 a.m. UTC
Currently the slope and offset values for calculating the
hot spot temperature of a particular thermal zone is part
of driver data. Pass them here instead and obtain the values
while of node parsing.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/boot/dts/omap5.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Eduardo Valentin March 29, 2017, 4:33 a.m. UTC | #1
On Thu, Mar 09, 2017 at 01:35:57PM +0530, Keerthy wrote:
> Currently the slope and offset values for calculating the
> hot spot temperature of a particular thermal zone is part
> of driver data. Pass them here instead and obtain the values
> while of node parsing.


The patch is fine.. but

> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  arch/arm/boot/dts/omap5.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index 222155c..eaff2a5 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -1127,6 +1127,15 @@
>  
>  &cpu_thermal {
>  	polling-delay = <500>; /* milliseconds */
> +	coefficients = <65 (-1791)>;

I suppose you tried this change with this patch:
https://patchwork.kernel.org/patch/9619577/
?

Otherwise, I do not see how your coeff would work, right?

>  };
>  
>  /include/ "omap54xx-clocks.dtsi"
> +
> +&gpu_thermal {
> +	coefficients = <117 (-2992)>;
> +};
> +
> +&core_thermal {
> +	coefficients = <0 2000>;
> +};
> -- 
> 1.9.1
>
J, KEERTHY March 30, 2017, 3:27 a.m. UTC | #2
On Wednesday 29 March 2017 10:03 AM, Eduardo Valentin wrote:
> On Thu, Mar 09, 2017 at 01:35:57PM +0530, Keerthy wrote:
>> Currently the slope and offset values for calculating the
>> hot spot temperature of a particular thermal zone is part
>> of driver data. Pass them here instead and obtain the values
>> while of node parsing.
> 
> 
> The patch is fine.. but
> 
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>  arch/arm/boot/dts/omap5.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
>> index 222155c..eaff2a5 100644
>> --- a/arch/arm/boot/dts/omap5.dtsi
>> +++ b/arch/arm/boot/dts/omap5.dtsi
>> @@ -1127,6 +1127,15 @@
>>  
>>  &cpu_thermal {
>>  	polling-delay = <500>; /* milliseconds */
>> +	coefficients = <65 (-1791)>;
> 
> I suppose you tried this change with this patch:
> https://patchwork.kernel.org/patch/9619577/
> ?
> 
> Otherwise, I do not see how your coeff would work, right?

IIRC i did not have that patch.

But No issues there. I did try deliberately with negative values and i
retrieved the negative values in driver nicely.

Fox ex: -20 unsigned when retrieved in driver as an int coeff will give
me -20. I checked with multiple negative co-efficients and i retrieved
the passed negative co-efficients in driver from DT.

Regards,
Keerthy


> 
>>  };
>>  
>>  /include/ "omap54xx-clocks.dtsi"
>> +
>> +&gpu_thermal {
>> +	coefficients = <117 (-2992)>;
>> +};
>> +
>> +&core_thermal {
>> +	coefficients = <0 2000>;
>> +};
>> -- 
>> 1.9.1
>>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 222155c..eaff2a5 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -1127,6 +1127,15 @@ 
 
 &cpu_thermal {
 	polling-delay = <500>; /* milliseconds */
+	coefficients = <65 (-1791)>;
 };
 
 /include/ "omap54xx-clocks.dtsi"
+
+&gpu_thermal {
+	coefficients = <117 (-2992)>;
+};
+
+&core_thermal {
+	coefficients = <0 2000>;
+};