diff mbox

power: supply: sbs-battery: fix the sbs interrupt request

Message ID 1492744397-7105-1-git-send-email-raitosyo@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

raitosyo@gmail.com April 21, 2017, 3:13 a.m. UTC 
From: Ryosuke Saito <raitosyo@gmail.com>

Since we use the default primary handler for the irq, IRQF_ONESHOT must
be set. Otherwise the request fails and the following errors are
displayed:

genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 129
sbs-battery 0-000b: Failed to request irq: -22

Signed-off-by: Ryosuke Saito <raitosyo@gmail.com>
---
 drivers/power/supply/sbs-battery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sebastian Reichel May 1, 2017, 11:31 a.m. UTC | #1 
Hi,

On Fri, Apr 21, 2017 at 12:13:17PM +0900, raitosyo@gmail.com wrote:
> From: Ryosuke Saito <raitosyo@gmail.com>
> 
> Since we use the default primary handler for the irq, IRQF_ONESHOT must
> be set. Otherwise the request fails and the following errors are
> displayed:
> 
> genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 129
> sbs-battery 0-000b: Failed to request irq: -22
> 
> Signed-off-by: Ryosuke Saito <raitosyo@gmail.com>

Thanks, queued.

-- Sebastian
diff mbox

Patch

diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c
index 8bb2eb3..e07d570 100644
--- a/drivers/power/supply/sbs-battery.c
+++ b/drivers/power/supply/sbs-battery.c
@@ -820,7 +820,7 @@  static int sbs_probe(struct i2c_client *client,
 	}
 
 	rc = devm_request_threaded_irq(&client->dev, irq, NULL, sbs_irq,
-		IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
+		IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 		dev_name(&client->dev), chip);
 	if (rc) {
 		dev_warn(&client->dev, "Failed to request irq: %d\n", rc);