| Message ID | 1496049345-14649-3-git-send-email-hayashi.kunihiko@socionext.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Eduardo Valentin |
| Headers | show |
On Mon, May 29, 2017 at 06:15:43PM +0900, Kunihiko Hayashi wrote: > Add devicetree binding documentation for thermal monitor implemented on > Socionext UniPhier SoCs. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../bindings/thermal/uniphier-thermal.txt | 54 ++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/uniphier-thermal.txt Acked-by: Rob Herring <robh@kernel.org>
2017-05-29 18:15 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>: > Add devicetree binding documentation for thermal monitor implemented on > Socionext UniPhier SoCs. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../bindings/thermal/uniphier-thermal.txt | 54 ++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/uniphier-thermal.txt > > diff --git a/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt b/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt > new file mode 100644 > index 0000000..72834e1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt > @@ -0,0 +1,54 @@ > +* UniPhier Thermal bindings > + > +This describes the devicetree bindings for thermal monitor supported by > +PVT(Process, Voltage and Temperature) monitoring unit implemented on Socionext > +UniPhier SoCs. This paragraph implies this might be a HWMON driver if more features are implemented, but I assume you use only the Temperature part for a thermal driver at the moment. (I do not know if other sensors are useful or not, so I do not mind it much.) > +Required properties: > +- compatible : > + - "socionext,uniphier-pxs2-thermal" : For UniPhier PXs2 SoC > + - "socionext,uniphier-ld20-thermal" : For UniPhier LD20 SoC > +- reg : Offset address of the thermal registers from sysctrl This "reg" does not exist in the example. Your driver code uses regmap for register access. > +- interrupts : IRQ for the temperature alarm > +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for details. > + > +Optional properties: > +- socionext,tmod-calibration: A pair of calibrated values referred from PVT, > + in case that the values aren't set on SoC, > + like a reference board. > + > +Example: > + > + sysctrl@61840000 { > + compatible = "socionext,uniphier-ld20-sysctrl", > + "simple-mfd", "syscon"; > + reg = <0x61840000 0x10000>; > + ... > + pvtctl: pvtctl { > + compatible = "socionext,uniphier-ld20-thermal"; > + interrupts = <0 3 1>; > + #thermal-sensor-cells = <0>; > + }; > + ... > + }; > + > + thermal-zones { > + cpu_thermal { > + polling-delay-passive = <250>; /* 250ms */ > + polling-delay = <1000>; /* 1000ms */ > + thermal-sensors = <&pvtctl>; > + > + trips { > + cpu_crit: cpu_crit { > + temperature = <95000>; /* 95C */ > + hysteresis = <2000>; > + type = "critical"; > + }; > + cpu_alert: cpu_alert { > + temperature = <85000>; /* 85C */ > + hysteresis = <2000>; > + type = "passive"; > + }; > + }; > + }; > + }; > -- > 2.7.4 >
diff --git a/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt b/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt new file mode 100644 index 0000000..72834e1 --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/uniphier-thermal.txt @@ -0,0 +1,54 @@ +* UniPhier Thermal bindings + +This describes the devicetree bindings for thermal monitor supported by +PVT(Process, Voltage and Temperature) monitoring unit implemented on Socionext +UniPhier SoCs. + +Required properties: +- compatible : + - "socionext,uniphier-pxs2-thermal" : For UniPhier PXs2 SoC + - "socionext,uniphier-ld20-thermal" : For UniPhier LD20 SoC +- reg : Offset address of the thermal registers from sysctrl +- interrupts : IRQ for the temperature alarm +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for details. + +Optional properties: +- socionext,tmod-calibration: A pair of calibrated values referred from PVT, + in case that the values aren't set on SoC, + like a reference board. + +Example: + + sysctrl@61840000 { + compatible = "socionext,uniphier-ld20-sysctrl", + "simple-mfd", "syscon"; + reg = <0x61840000 0x10000>; + ... + pvtctl: pvtctl { + compatible = "socionext,uniphier-ld20-thermal"; + interrupts = <0 3 1>; + #thermal-sensor-cells = <0>; + }; + ... + }; + + thermal-zones { + cpu_thermal { + polling-delay-passive = <250>; /* 250ms */ + polling-delay = <1000>; /* 1000ms */ + thermal-sensors = <&pvtctl>; + + trips { + cpu_crit: cpu_crit { + temperature = <95000>; /* 95C */ + hysteresis = <2000>; + type = "critical"; + }; + cpu_alert: cpu_alert { + temperature = <85000>; /* 85C */ + hysteresis = <2000>; + type = "passive"; + }; + }; + }; + };
Add devicetree binding documentation for thermal monitor implemented on Socionext UniPhier SoCs. Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- .../bindings/thermal/uniphier-thermal.txt | 54 ++++++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/uniphier-thermal.txt