| Message ID | 1496260544-4200-1-git-send-email-jon.mason@broadcom.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 05/31/2017 12:55 PM, Jon Mason wrote: > ARCH_BCM_IPROC includes support for many SoCs, not all of which have the > same thermal hardware interface as the Northstar/Northstar Plus SoCs. > This is not a major issue, as this driver will only be probed if the > relevant device tree entry is present. However, it will result in a > slightly larger than necessary kernel. By limiting the driver to only > work on the NS/NSP SoCs, we can avoid the issue. > > Suggested-by: Scott Branden <scott.branden@broadcom.com> > Signed-off-by: Jon Mason <jon.mason@broadcom.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
On Wed, May 31, 2017 at 03:55:44PM -0400, Jon Mason wrote: > ARCH_BCM_IPROC includes support for many SoCs, not all of which have the > same thermal hardware interface as the Northstar/Northstar Plus SoCs. > This is not a major issue, as this driver will only be probed if the > relevant device tree entry is present. However, it will result in a > slightly larger than necessary kernel. By limiting the driver to only > work on the NS/NSP SoCs, we can avoid the issue. > > Suggested-by: Scott Branden <scott.branden@broadcom.com> > Signed-off-by: Jon Mason <jon.mason@broadcom.com> Should this commit message include a Fixes: tag? Maybe Fixes: a94cb7e ("thermal: broadcom: add Northstar thermal driver") > --- > drivers/thermal/broadcom/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig > index 42c098e86f84..c729dad2348c 100644 > --- a/drivers/thermal/broadcom/Kconfig > +++ b/drivers/thermal/broadcom/Kconfig > @@ -8,8 +8,8 @@ config BCM2835_THERMAL > > config BCM_NS_THERMAL > tristate "Northstar thermal driver" > - depends on ARCH_BCM_IPROC || COMPILE_TEST > - default y if ARCH_BCM_IPROC > + depends on ARCH_BCM_NSP || ARCH_BCM_5301X || COMPILE_TEST > + default y if ARCH_BCM_NSP || ARCH_BCM_5301X > help > Support for the Northstar and Northstar Plus family of SoCs (e.g. > BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device > -- > 2.7.4 >
On 2017-05-31 21:55, Jon Mason wrote: > ARCH_BCM_IPROC includes support for many SoCs, not all of which have > the > same thermal hardware interface as the Northstar/Northstar Plus SoCs. > This is not a major issue, as this driver will only be probed if the > relevant device tree entry is present. However, it will result in a > slightly larger than necessary kernel. By limiting the driver to only > work on the NS/NSP SoCs, we can avoid the issue. > > Suggested-by: Scott Branden <scott.branden@broadcom.com> > Signed-off-by: Jon Mason <jon.mason@broadcom.com> Sounds OK, thanks.
On Wed, May 31, 2017 at 11:09 PM, Eduardo Valentin <edubezval@gmail.com> wrote: > On Wed, May 31, 2017 at 03:55:44PM -0400, Jon Mason wrote: >> ARCH_BCM_IPROC includes support for many SoCs, not all of which have the >> same thermal hardware interface as the Northstar/Northstar Plus SoCs. >> This is not a major issue, as this driver will only be probed if the >> relevant device tree entry is present. However, it will result in a >> slightly larger than necessary kernel. By limiting the driver to only >> work on the NS/NSP SoCs, we can avoid the issue. >> >> Suggested-by: Scott Branden <scott.branden@broadcom.com> >> Signed-off-by: Jon Mason <jon.mason@broadcom.com> > > Should this commit message include a Fixes: tag? > > Maybe > Fixes: a94cb7e ("thermal: broadcom: add Northstar thermal driver") Technically, it would be 2 patches Fixes: a94cb7eeecc4 ("thermal: broadcom: add Northstar thermal driver") Fixes: a54c51863ed1 ("thermal: broadcom: ns-thermal: default on iProc SoCs") We could probably get away with only doing the latter one, as it is the one that makes it enabled by default >> --- >> drivers/thermal/broadcom/Kconfig | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig >> index 42c098e86f84..c729dad2348c 100644 >> --- a/drivers/thermal/broadcom/Kconfig >> +++ b/drivers/thermal/broadcom/Kconfig >> @@ -8,8 +8,8 @@ config BCM2835_THERMAL >> >> config BCM_NS_THERMAL >> tristate "Northstar thermal driver" >> - depends on ARCH_BCM_IPROC || COMPILE_TEST >> - default y if ARCH_BCM_IPROC >> + depends on ARCH_BCM_NSP || ARCH_BCM_5301X || COMPILE_TEST >> + default y if ARCH_BCM_NSP || ARCH_BCM_5301X >> help >> Support for the Northstar and Northstar Plus family of SoCs (e.g. >> BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device >> -- >> 2.7.4 >>
diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig index 42c098e86f84..c729dad2348c 100644 --- a/drivers/thermal/broadcom/Kconfig +++ b/drivers/thermal/broadcom/Kconfig @@ -8,8 +8,8 @@ config BCM2835_THERMAL config BCM_NS_THERMAL tristate "Northstar thermal driver" - depends on ARCH_BCM_IPROC || COMPILE_TEST - default y if ARCH_BCM_IPROC + depends on ARCH_BCM_NSP || ARCH_BCM_5301X || COMPILE_TEST + default y if ARCH_BCM_NSP || ARCH_BCM_5301X help Support for the Northstar and Northstar Plus family of SoCs (e.g. BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device
ARCH_BCM_IPROC includes support for many SoCs, not all of which have the same thermal hardware interface as the Northstar/Northstar Plus SoCs. This is not a major issue, as this driver will only be probed if the relevant device tree entry is present. However, it will result in a slightly larger than necessary kernel. By limiting the driver to only work on the NS/NSP SoCs, we can avoid the issue. Suggested-by: Scott Branden <scott.branden@broadcom.com> Signed-off-by: Jon Mason <jon.mason@broadcom.com> --- drivers/thermal/broadcom/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)