From patchwork Tue Sep 26 23:50:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 9972849 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F3E7F60249 for ; Tue, 26 Sep 2017 23:54:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E930328535 for ; Tue, 26 Sep 2017 23:54:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DC9392900A; Tue, 26 Sep 2017 23:54:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5372D28535 for ; Tue, 26 Sep 2017 23:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032704AbdIZXxg (ORCPT ); Tue, 26 Sep 2017 19:53:36 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:49373 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967407AbdIZXxg (ORCPT ); Tue, 26 Sep 2017 19:53:36 -0400 Received: by mail-wm0-f41.google.com with SMTP id r74so12671199wme.4 for ; Tue, 26 Sep 2017 16:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=dohuYtmbBQqt09ape1TFhBpj7e534EG+iGnCtAT4Av4=; b=aR0fmMQe41yaXqOrdBx0qhEhSvCr5+p15vxjHzZQAYq2SMJ7NxhsKWeKYYw1aNWzrI kZ3G4yiyZjTQYm4KLb6JWNy+RPuGy+R1n2BTBnPK6u1v8ncfmJOhjoP2mGCUtteBMTD0 azEUQtkrSWLCq8rkyOQn/CAOIqjxRlo/WNjkQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dohuYtmbBQqt09ape1TFhBpj7e534EG+iGnCtAT4Av4=; b=Ys328rbI+gWT3Vo+iceDI9TtoEsNhhwzQwz7gXBwI+WxqpGcdA2DV7nksxAlZ4uXuL Z3BCReV61OM6dXVAnduep5bkosRs+WTthND8krf6RiMAFU0+ukIINOr15kcDdyJXeOan VxtUScU7mH5C7O8GMu3hFynIDZWgxwioAEXfXi5UUdMOJqJJHBD96E7o4npFLvB84NuD 4K4efFp5YzpO7zuFh4GIHFkwuQMXGkQEYcnysj+rg7VKjeeVXnkCav+O6+CIlQqw30sV do0qNbyLtLOlqZmeHS5ea7TaXLSCiDmFKRjU/hK4GVxm4dw6GkYMqO9mMd377LlOTV7c UHMg== X-Gm-Message-State: AMCzsaVxyyv3Hm1k+/nPtccY3tR3ODRyTwJZKlu6VS7CwcSnqLY9b28C QL9GB6Z0+3nMDdB8ww9haWYqwA== X-Google-Smtp-Source: AOwi7QAJyreNo1K282DaV4fB1Qwxs6lPA5x8YBQvYOnlEIcmGIX9TJxxjAFdIVPViHh0rxXlNQrEyw== X-Received: by 10.28.30.22 with SMTP id e22mr16911wme.121.1506470014847; Tue, 26 Sep 2017 16:53:34 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:879a:6cd0:901b:4425:ce24:a9c0]) by smtp.gmail.com with ESMTPSA id x185sm2313745wmx.35.2017.09.26.16.53.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Sep 2017 16:53:33 -0700 (PDT) From: Daniel Lezcano To: edubezval@gmail.com Cc: Zhang Rui , linux-pm@vger.kernel.org (open list:THERMAL), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] thermal/drivers/qcom-spmi: Use devm_iio_channel_get Date: Wed, 27 Sep 2017 01:50:55 +0200 Message-Id: <1506469855-12497-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The iio_channel_get() function has now its devm_ version. Use it and remove all the rollback code for iio_channel_release() as well as the .remove ops. [Compiled tested only] Signed-off-by: Daniel Lezcano --- drivers/thermal/qcom-spmi-temp-alarm.c | 43 +++++++++++----------------------- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/drivers/thermal/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom-spmi-temp-alarm.c index f502419..95f987d 100644 --- a/drivers/thermal/qcom-spmi-temp-alarm.c +++ b/drivers/thermal/qcom-spmi-temp-alarm.c @@ -125,7 +125,7 @@ static int qpnp_tm_get_temp(void *data, int *temp) if (!temp) return -EINVAL; - if (IS_ERR(chip->adc)) { + if (!chip->adc) { ret = qpnp_tm_update_temp_no_adc(chip); if (ret < 0) return ret; @@ -224,67 +224,53 @@ static int qpnp_tm_probe(struct platform_device *pdev) return irq; /* ADC based measurements are optional */ - chip->adc = iio_channel_get(&pdev->dev, "thermal"); - if (PTR_ERR(chip->adc) == -EPROBE_DEFER) - return PTR_ERR(chip->adc); + chip->adc = devm_iio_channel_get(&pdev->dev, "thermal"); + if (IS_ERR(chip->adc)) { + ret = PTR_ERR(chip->adc); + chip->adc = NULL; + if (ret == -EPROBE_DEFER) + return ret; + } chip->base = res; ret = qpnp_tm_read(chip, QPNP_TM_REG_TYPE, &type); if (ret < 0) { dev_err(&pdev->dev, "could not read type\n"); - goto fail; + return ret; } ret = qpnp_tm_read(chip, QPNP_TM_REG_SUBTYPE, &subtype); if (ret < 0) { dev_err(&pdev->dev, "could not read subtype\n"); - goto fail; + return ret; } if (type != QPNP_TM_TYPE || subtype != QPNP_TM_SUBTYPE) { dev_err(&pdev->dev, "invalid type 0x%02x or subtype 0x%02x\n", type, subtype); - ret = -ENODEV; - goto fail; + return -ENODEV; } ret = qpnp_tm_init(chip); if (ret < 0) { dev_err(&pdev->dev, "init failed\n"); - goto fail; + return ret; } ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, qpnp_tm_isr, IRQF_ONESHOT, node->name, chip); if (ret < 0) - goto fail; + return ret; chip->tz_dev = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, chip, &qpnp_tm_sensor_ops); if (IS_ERR(chip->tz_dev)) { dev_err(&pdev->dev, "failed to register sensor\n"); - ret = PTR_ERR(chip->tz_dev); - goto fail; + return PTR_ERR(chip->tz_dev); } return 0; - -fail: - if (!IS_ERR(chip->adc)) - iio_channel_release(chip->adc); - - return ret; -} - -static int qpnp_tm_remove(struct platform_device *pdev) -{ - struct qpnp_tm_chip *chip = dev_get_drvdata(&pdev->dev); - - if (!IS_ERR(chip->adc)) - iio_channel_release(chip->adc); - - return 0; } static const struct of_device_id qpnp_tm_match_table[] = { @@ -299,7 +285,6 @@ static struct platform_driver qpnp_tm_driver = { .of_match_table = qpnp_tm_match_table, }, .probe = qpnp_tm_probe, - .remove = qpnp_tm_remove, }; module_platform_driver(qpnp_tm_driver);