| Message ID | 1507649178-31473-4-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers | show |
On Tue, 10 Oct 2017, Geert Uytterhoeven wrote: > Enable read/write access to the BD9571MWV_BKUP_MODE_CNT register, which > is a.o. used to configure DDR Backup Power. a.o.? That's a new one on me. Please ensure commit logs are clear for *everyone* to read/understand by using descriptive and expanded (rather than shorten) terms. Code looks fine though, so once fixed: For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
Hi Lee, On Fri, Oct 13, 2017 at 10:58 AM, Lee Jones <lee.jones@linaro.org> wrote: > On Tue, 10 Oct 2017, Geert Uytterhoeven wrote: > >> Enable read/write access to the BD9571MWV_BKUP_MODE_CNT register, which >> is a.o. used to configure DDR Backup Power. > > a.o.? That's a new one on me. among(st) others Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, 13 Oct 2017, Geert Uytterhoeven wrote: > Hi Lee, > > On Fri, Oct 13, 2017 at 10:58 AM, Lee Jones <lee.jones@linaro.org> wrote: > > On Tue, 10 Oct 2017, Geert Uytterhoeven wrote: > > > >> Enable read/write access to the BD9571MWV_BKUP_MODE_CNT register, which > >> is a.o. used to configure DDR Backup Power. > > > > a.o.? That's a new one on me. > > among(st) others Please just write that instead. :)
diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c index 64e088dfe7b05b5b..503979c81dae11bb 100644 --- a/drivers/mfd/bd9571mwv.c +++ b/drivers/mfd/bd9571mwv.c @@ -29,6 +29,7 @@ static const struct mfd_cell bd9571mwv_cells[] = { static const struct regmap_range bd9571mwv_readable_yes_ranges[] = { regmap_reg_range(BD9571MWV_VENDOR_CODE, BD9571MWV_PRODUCT_REVISION), + regmap_reg_range(BD9571MWV_BKUP_MODE_CNT, BD9571MWV_BKUP_MODE_CNT), regmap_reg_range(BD9571MWV_AVS_SET_MONI, BD9571MWV_AVS_DVFS_VID(3)), regmap_reg_range(BD9571MWV_VD18_VID, BD9571MWV_VD33_VID), regmap_reg_range(BD9571MWV_DVFS_VINIT, BD9571MWV_DVFS_VINIT), @@ -44,6 +45,7 @@ static const struct regmap_access_table bd9571mwv_readable_table = { }; static const struct regmap_range bd9571mwv_writable_yes_ranges[] = { + regmap_reg_range(BD9571MWV_BKUP_MODE_CNT, BD9571MWV_BKUP_MODE_CNT), regmap_reg_range(BD9571MWV_AVS_VD09_VID(0), BD9571MWV_AVS_VD09_VID(3)), regmap_reg_range(BD9571MWV_DVFS_SETVID, BD9571MWV_DVFS_SETVID), regmap_reg_range(BD9571MWV_GPIO_DIR, BD9571MWV_GPIO_OUT),
Enable read/write access to the BD9571MWV_BKUP_MODE_CNT register, which is a.o. used to configure DDR Backup Power. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/mfd/bd9571mwv.c | 2 ++ 1 file changed, 2 insertions(+)