| Message ID | 1508318150-108444-1-git-send-email-kevin.wangtao@hisilicon.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Eduardo Valentin |
| Headers | show |
On 18/10/2017 11:15, Tao Wang wrote: > From: Kevin Wangtao <kevin.wangtao@linaro.org> > > multi alarm interrupt forced a re-trigger of power_allocator_throttle > which changes the PID's actual sampling rate, this isn't optimal for > IPA, it is best to disable multi alarm support now and sort out this > issue later. > > Signed-off-by: Kevin Wangtao <kevin.wangtao@linaro.org> Did you test the series with this change? > --- > drivers/thermal/hisi_thermal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c > index 133238a..3b74c12 100644 > --- a/drivers/thermal/hisi_thermal.c > +++ b/drivers/thermal/hisi_thermal.c > @@ -360,7 +360,6 @@ static int hi3660_thermal_enable_sensor(struct hisi_thermal_data *data) > > /* set interrupt threshold */ > value = hi3660_thermal_temp_to_step(sensor->thres_temp[0]); > - value |= hi3660_thermal_temp_to_step(sensor->thres_temp[1]) << 10; > hi3660_thermal_alarm_set(data->regs, sensor->id, value); > > /* enable interrupt */ >
在 2017/10/18 23:54, Daniel Lezcano 写道: > On 18/10/2017 11:15, Tao Wang wrote: >> From: Kevin Wangtao <kevin.wangtao@linaro.org> >> >> multi alarm interrupt forced a re-trigger of power_allocator_throttle >> which changes the PID's actual sampling rate, this isn't optimal for >> IPA, it is best to disable multi alarm support now and sort out this >> issue later. >> >> Signed-off-by: Kevin Wangtao <kevin.wangtao@linaro.org> > > Did you test the series with this change? Yes > >> --- >> drivers/thermal/hisi_thermal.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c >> index 133238a..3b74c12 100644 >> --- a/drivers/thermal/hisi_thermal.c >> +++ b/drivers/thermal/hisi_thermal.c >> @@ -360,7 +360,6 @@ static int hi3660_thermal_enable_sensor(struct hisi_thermal_data *data) >> >> /* set interrupt threshold */ >> value = hi3660_thermal_temp_to_step(sensor->thres_temp[0]); >> - value |= hi3660_thermal_temp_to_step(sensor->thres_temp[1]) << 10; >> hi3660_thermal_alarm_set(data->regs, sensor->id, value); >> >> /* enable interrupt */ >> > >
Hello, On Thu, Oct 19, 2017 at 09:31:24AM +0800, Wangtao (Kevin, Kirin) wrote: > > > 在 2017/10/18 23:54, Daniel Lezcano 写道: > >On 18/10/2017 11:15, Tao Wang wrote: > >>From: Kevin Wangtao <kevin.wangtao@linaro.org> > >> > >>multi alarm interrupt forced a re-trigger of power_allocator_throttle > >>which changes the PID's actual sampling rate, this isn't optimal for > >>IPA, it is best to disable multi alarm support now and sort out this > >>issue later. > >> > >>Signed-off-by: Kevin Wangtao <kevin.wangtao@linaro.org> > > > >Did you test the series with this change? > Yes Is this patch still valid with the latest linus master?
On 05/12/2017 03:02, Eduardo Valentin wrote: > Hello, > > On Thu, Oct 19, 2017 at 09:31:24AM +0800, Wangtao (Kevin, Kirin) wrote: >> >> >> 在 2017/10/18 23:54, Daniel Lezcano 写道: >>> On 18/10/2017 11:15, Tao Wang wrote: >>>> From: Kevin Wangtao <kevin.wangtao@linaro.org> >>>> >>>> multi alarm interrupt forced a re-trigger of power_allocator_throttle >>>> which changes the PID's actual sampling rate, this isn't optimal for >>>> IPA, it is best to disable multi alarm support now and sort out this >>>> issue later. >>>> >>>> Signed-off-by: Kevin Wangtao <kevin.wangtao@linaro.org> >>> >>> Did you test the series with this change? >> Yes > > Is this patch still valid with the latest linus master? No, it was folded in the next iteration. All patches for hisilicon are up-to-date. Thanks. -- Daniel
diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c index 133238a..3b74c12 100644 --- a/drivers/thermal/hisi_thermal.c +++ b/drivers/thermal/hisi_thermal.c @@ -360,7 +360,6 @@ static int hi3660_thermal_enable_sensor(struct hisi_thermal_data *data) /* set interrupt threshold */ value = hi3660_thermal_temp_to_step(sensor->thres_temp[0]); - value |= hi3660_thermal_temp_to_step(sensor->thres_temp[1]) << 10; hi3660_thermal_alarm_set(data->regs, sensor->id, value); /* enable interrupt */