From patchwork Thu Oct 19 17:05:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 10017887 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B7EB9602C8 for ; Thu, 19 Oct 2017 17:13:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A076F28D55 for ; Thu, 19 Oct 2017 17:13:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9568F28DD5; Thu, 19 Oct 2017 17:13:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E64928D55 for ; Thu, 19 Oct 2017 17:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755017AbdJSRIh (ORCPT ); Thu, 19 Oct 2017 13:08:37 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:51796 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298AbdJSRIe (ORCPT ); Thu, 19 Oct 2017 13:08:34 -0400 Received: by mail-wm0-f67.google.com with SMTP id f4so17754970wme.0 for ; Thu, 19 Oct 2017 10:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=b1XO1Q6oDJ+0Zqsb1mpoVsrFtWrFMVdCtEDLzYWAduw=; b=NfTva1ov5vV73p4Gco+pnyW2XhwHN5uWqlrEAjBOtaVjtGHgps0KSvP9LfyKaNCZWX IQUmw8LwpzIFfR7vdWYRbEe9R6OeSXo/6fbrp+GqEM9jVke+OeCwwDw+t2p9UbWsKx9q LKe7tV9U1coEloDb2o1E0Yrgw4JbYFzph/vgA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=b1XO1Q6oDJ+0Zqsb1mpoVsrFtWrFMVdCtEDLzYWAduw=; b=hdtjSBESB6UUYdQJncfKpuqHPFjZujXt2US5GW0GdW1JCPYD7NehXsCKC68c5HnPjB +3bw/hYRpHEGvXN7+vR2lg+tyCvK7gMGz9M/VTzHcsWeJS4fpzDIKuMShD6qFX/6rFwj 64GQTPiQXCURCvevKQ8Sb+P0pPi6Soa/XlQ7yhYFGgpE/JqK6AIDT56o6WrR8Vi15woS DcwhalKJEpU0Mi02oNl0uqFW/z/bQXQ/Aveo0UWLy0JCF2rWT0/dgOAkVwlSVs9fU5XM QLyyVOyxh/I456OhpuH7ZOWpCQOsAGsM1Jvlb27ljkB8C/ILFxcYVY6WJDozuXYBAQId fhNg== X-Gm-Message-State: AMCzsaWnb8oNmOmoBYCgvwLxoCQqWAukO8jqP6MkeMmofWevs2b6C4Us VGaHKDx8+DSzB9NfL4SOURwavA== X-Google-Smtp-Source: ABhQp+QRcTQ+99md1v4YlbzHK/FE+akPfqqbmjlYZIPjULUqOtpKolT9dgij20jRFlBOUqkkdajL8w== X-Received: by 10.28.184.141 with SMTP id i135mr2414871wmf.143.1508432912971; Thu, 19 Oct 2017 10:08:32 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:879a:6cd0:51c7:d9b7:e14b:6840]) by smtp.gmail.com with ESMTPSA id g16sm14277394wrd.72.2017.10.19.10.08.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Oct 2017 10:08:32 -0700 (PDT) From: Daniel Lezcano To: edubezval@gmail.com, rui.zhang@intel.com Cc: linux-pm@vger.kernel.org, leo.yan@linaro.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/18] thermal/drivers/hisi: Fix kernel panic on alarm interrupt Date: Thu, 19 Oct 2017 19:05:45 +0200 Message-Id: <1508432760-17847-3-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1508432760-17847-1-git-send-email-daniel.lezcano@linaro.org> References: <6ac48f08-7fe6-92e9-0801-6ed3bcd05ff1@linaro.org> <1508432760-17847-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The threaded interrupt for the alarm interrupt is requested before the temperature controller is setup. This one can fire an interrupt immediately leading to a kernel panic as the sensor data is not initialized. In order to prevent that, move the threaded irq after the Tsensor is setup. Signed-off-by: Daniel Lezcano Reviewed-by: Leo Yan Tested-by: Leo Yan --- drivers/thermal/hisi_thermal.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c index 687efd4..feae552 100644 --- a/drivers/thermal/hisi_thermal.c +++ b/drivers/thermal/hisi_thermal.c @@ -287,15 +287,6 @@ static int hisi_thermal_probe(struct platform_device *pdev) if (data->irq < 0) return data->irq; - ret = devm_request_threaded_irq(&pdev->dev, data->irq, - hisi_thermal_alarm_irq, - hisi_thermal_alarm_irq_thread, - 0, "hisi_thermal", data); - if (ret < 0) { - dev_err(&pdev->dev, "failed to request alarm irq: %d\n", ret); - return ret; - } - platform_set_drvdata(pdev, data); data->clk = devm_clk_get(&pdev->dev, "thermal_clk"); @@ -328,6 +319,15 @@ static int hisi_thermal_probe(struct platform_device *pdev) hisi_thermal_toggle_sensor(&data->sensors, true); + ret = devm_request_threaded_irq(&pdev->dev, data->irq, + hisi_thermal_alarm_irq, + hisi_thermal_alarm_irq_thread, + 0, "hisi_thermal", data); + if (ret < 0) { + dev_err(&pdev->dev, "failed to request alarm irq: %d\n", ret); + return ret; + } + enable_irq(data->irq); return 0;