From patchwork Mon Nov 13 15:46:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 10056321 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3584860365 for ; Mon, 13 Nov 2017 15:46:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 28CBE292A1 for ; Mon, 13 Nov 2017 15:46:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1D15429428; Mon, 13 Nov 2017 15:46:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BBD79292A1 for ; Mon, 13 Nov 2017 15:46:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbdKMPqy (ORCPT ); Mon, 13 Nov 2017 10:46:54 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:47728 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753296AbdKMPqw (ORCPT ); Mon, 13 Nov 2017 10:46:52 -0500 Received: by mail-lf0-f67.google.com with SMTP id f125so18821249lff.4 for ; Mon, 13 Nov 2017 07:46:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z6bveg9k5fuh6Zc3zXkVbIClpgXuD92B/ZJ5LBm0oEA=; b=axzqIC21UUrAiobfexalgdfWCbtSEgQaDrD1hf3JbbXAKjwITCkzFbunvExsTpHLyN YWHVnv9Mo3NzWX+ammE2/SSx0gKDUAQOAyqbEKkRzKAvp6Yo00CwdpFAUbpuvbIYzDOR 7SFs28mkExJxZHGEWKxG2hxK/YgbvP62V4yRc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z6bveg9k5fuh6Zc3zXkVbIClpgXuD92B/ZJ5LBm0oEA=; b=Ri0MAUwhyrwEO3JachnqHYs/h+A+cnqW2RFp+hhYSISIfNrZZHna1QtJ5P+2cMnT9O fBoo8bzVVzCu8sgfbZ5TYHggpwMe2b7a5ult+Gv7w+zvxjZHpaE5lqrtBRr3bmIYWORb V+RFAnXLM+sVb6qWrigInUXauQHFUqTii1YNJzIhJ4OZ0ZlHMA1HLUWOAjZC7emRwYJ8 eklOyNq58ljX4Ts8Ku0d3Z3Yr+8bFdo/xpMANTA4AEQrAzjum64hWNHV20do6knZ6UXN TRdM/nMerg7ijunuO4UpH4e7iERhsJl/UIvgEbz6avDui9AgWFKvegdVODVui7h7GQ47 V5Yw== X-Gm-Message-State: AJaThX4IF/HrPJMrZMOLaYyevNBSO/TUE4EXkH1MvcccMDA08xgQTn1M Thk/nyLqlqonwI92MYxsbqrFfw== X-Google-Smtp-Source: AGs4zMbOlCK49SxzKGM+sdyivoPsIgfIY8c7LAS+4Fir7yJoCxx/0qarD2Cn2MZ5kaBuiWI+vov4UQ== X-Received: by 10.25.193.81 with SMTP id r78mr2980762lff.187.1510588011263; Mon, 13 Nov 2017 07:46:51 -0800 (PST) Received: from localhost.localdomain (h-158-174-22-67.NA.cust.bahnhof.se. [158.174.22.67]) by smtp.gmail.com with ESMTPSA id m26sm177841ljb.61.2017.11.13.07.46.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 Nov 2017 07:46:50 -0800 (PST) From: Ulf Hansson To: "Rafael J . Wysocki" , linux-pm@vger.kernel.org Cc: Kevin Hilman , Viresh Kumar , Geert Uytterhoeven , Simon Horman , Niklas Soderlund , linux-renesas-soc@vger.kernel.org, Ulf Hansson Subject: [PATCH v2 1/3] PM / core: Re-factor some code dealing with parents in __device_suspend() Date: Mon, 13 Nov 2017 16:46:41 +0100 Message-Id: <1510588003-16650-2-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510588003-16650-1-git-send-email-ulf.hansson@linaro.org> References: <1510588003-16650-1-git-send-email-ulf.hansson@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Let's make the code a bit more readable by moving some of the code, which deals with adjustments for parent devices in __device_suspend(), into its own function. Signed-off-by: Ulf Hansson Reviewed-by: Geert Uytterhoeven --- Changes in v2: - Added Geert's Reviewed-by tag. --- drivers/base/power/main.c | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index 6c6f1c7..8089e72 100644 --- a/drivers/base/power/main.c +++ b/drivers/base/power/main.c @@ -1422,6 +1422,22 @@ static int legacy_suspend(struct device *dev, pm_message_t state, return error; } +static void dpm_propagate_to_parent(struct device *dev) +{ + struct device *parent = dev->parent; + + if (!parent) + return; + + spin_lock_irq(&parent->power.lock); + + parent->power.direct_complete = false; + if (dev->power.wakeup_path && !parent->power.ignore_children) + parent->power.wakeup_path = true; + + spin_unlock_irq(&parent->power.lock); +} + static void dpm_clear_suppliers_direct_complete(struct device *dev) { struct device_link *link; @@ -1530,19 +1546,8 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async) End: if (!error) { - struct device *parent = dev->parent; - dev->power.is_suspended = true; - if (parent) { - spin_lock_irq(&parent->power.lock); - - dev->parent->power.direct_complete = false; - if (dev->power.wakeup_path - && !dev->parent->power.ignore_children) - dev->parent->power.wakeup_path = true; - - spin_unlock_irq(&parent->power.lock); - } + dpm_propagate_to_parent(dev); dpm_clear_suppliers_direct_complete(dev); }