From patchwork Sat Mar 24 21:36:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 10306429 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1BB4F60386 for ; Sat, 24 Mar 2018 21:37:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E697A2930D for ; Sat, 24 Mar 2018 21:37:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DAF1A29328; Sat, 24 Mar 2018 21:37:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E9CD22930D for ; Sat, 24 Mar 2018 21:37:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752924AbeCXVhD (ORCPT ); Sat, 24 Mar 2018 17:37:03 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:33170 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752899AbeCXVhC (ORCPT ); Sat, 24 Mar 2018 17:37:02 -0400 Received: by mail-qt0-f195.google.com with SMTP id i8so16084645qtj.0 for ; Sat, 24 Mar 2018 14:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=xdIORGA5flL+jzGZtIt7fA1Px/ywGD2st6R+XHtZq18=; b=DtfoHEeWDVrKrDXAV1Ptkjsr6Hkzum6EbR+aFHlE+8yu0vZFfsA+cZhcZTKjD3lozJ W24GKPrKgpr4IBOBBNspdwtx9ihEDcxaD2nXBUUViDWes7fh6mcwKXkwT6BUq4mF4qgy eJcgn7i906zj7IMMRPksDtYjlIbW+SSvWfSiQyg+2lLgOVQ2jALoc7uKK3impPzLJBET 6IH9ht/+BuUDU5wBoGabr1ljkXCrsUSgCp0887ldTa7fGCUv/+KjumWJItEKkLIOuM32 2X0bUMiAttVLrTtk1QQC+Zev1pFm8WMkgHNwzXx7YoCLYh+9AmaJm/L0A+wAsnUF3gdw TR2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xdIORGA5flL+jzGZtIt7fA1Px/ywGD2st6R+XHtZq18=; b=OraJwYe4INNqVNjD3xRSWg7XZXUqTvMDtrTFuWMJ0I1z3Cyqfoe0invPeZt8ZDviT5 fP/ShxnzN8KFMqn/+pr3cdTlNQcUbBUg1f2BorEpWpD0jLPpYh9itwXxskEpuArlInTY SV9vVPd6mLZpaVjyOFedRk4DAu5gzMWXmcjhdZkUA8nlR/sO1yC227lRqj/fFELDWLEe 9HYuRCuYqjuY0OTU6OtBRhIuqwlfe6SaMRVnoG5W8ij+vIXQgjGEwA6atI7MtOi/aXz2 TbNWDd9XvP528iDKQhi6KCbCu8PhuMiyUjggoDvuLQAnqaeLBxy5X0OAo+JMgtSPtzCl GuOQ== X-Gm-Message-State: AElRT7EJ61g/CkIvhPWNusYkWadEmOhfPhGvp+jeWc0h4NZlvLcd0x3G JGbsXi17DnOVx5SQx7wtXIc= X-Google-Smtp-Source: AG47ELsqsbKkS972FTXC3tMv2Qu+xkkrfweFffmCN9EYyQNukfzgglBIV792X8JwjJV7FIwKXfP7CA== X-Received: by 10.237.57.5 with SMTP id l5mr43611948qte.200.1521927422016; Sat, 24 Mar 2018 14:37:02 -0700 (PDT) Received: from localhost.localdomain ([187.180.181.214]) by smtp.gmail.com with ESMTPSA id 25sm6982441qtv.28.2018.03.24.14.37.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 24 Mar 2018 14:37:01 -0700 (PDT) From: Fabio Estevam To: rjw@rjwysocki.net Cc: viresh.kumar@linaro.org, ego@linux.vnet.ibm.com, linux-pm@vger.kernel.org, Fabio Estevam Subject: [PATCH v3 1/2] cpufreq: powernv: Check for kmalloc() failure Date: Sat, 24 Mar 2018 18:36:51 -0300 Message-Id: <1521927412-14910-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam kmalloc() may fail, so we should better check for error and propagate the error in the case of allocation failure. This avoids a potential NULL pointer dereference later on. Signed-off-by: Fabio Estevam --- Changes since v2: - s/devm_kzalloc/kmalloc in the Subject line Changes since v1: - s/devm_kzalloc/kmalloc in the commit log drivers/cpufreq/powernv-cpufreq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 0591874..4ddfec9 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -329,6 +329,8 @@ static int init_powernv_pstates(void) revmap_data = (struct pstate_idx_revmap_data *) kmalloc(sizeof(*revmap_data), GFP_KERNEL); + if (!revmap_data) + return -ENOMEM; revmap_data->pstate_id = id & 0xFF; revmap_data->cpufreq_table_idx = i;