diff mbox

PM / Domains: Improve wording of dev_pm_domain_attach() comment

Message ID 1526390503-12846-1-git-send-email-geert+renesas@glider.be (mailing list archive)
State Mainlined
Delegated to: Rafael Wysocki
Headers show

Commit Message

Geert Uytterhoeven May 15, 2018, 1:21 p.m. UTC
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/base/power/common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ulf Hansson May 16, 2018, 8:59 a.m. UTC | #1
On 15 May 2018 at 15:21, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

> ---
>  drivers/base/power/common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/common.c b/drivers/base/power/common.c
> index 390868c2b392d57d..7ae62b6355b8d9ce 100644
> --- a/drivers/base/power/common.c
> +++ b/drivers/base/power/common.c
> @@ -98,8 +98,8 @@ EXPORT_SYMBOL_GPL(dev_pm_put_subsys_data);
>   * Callers must ensure proper synchronization of this function with power
>   * management callbacks.
>   *
> - * Returns 0 on successfully attached PM domain and when it found that the
> - * device don't need a PM domain, else a negative error code.
> + * Returns 0 on successfully attached PM domain, or when it is found that the
> + * device doesn't need a PM domain, else a negative error code.
>   */
>  int dev_pm_domain_attach(struct device *dev, bool power_on)
>  {
> --
> 2.7.4
>
Rafael J. Wysocki May 24, 2018, 9:32 a.m. UTC | #2
On Wednesday, May 16, 2018 10:59:04 AM CEST Ulf Hansson wrote:
> On 15 May 2018 at 15:21, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
> 
> Kind regards
> Uffe
> 
> > ---
> >  drivers/base/power/common.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/base/power/common.c b/drivers/base/power/common.c
> > index 390868c2b392d57d..7ae62b6355b8d9ce 100644
> > --- a/drivers/base/power/common.c
> > +++ b/drivers/base/power/common.c
> > @@ -98,8 +98,8 @@ EXPORT_SYMBOL_GPL(dev_pm_put_subsys_data);
> >   * Callers must ensure proper synchronization of this function with power
> >   * management callbacks.
> >   *
> > - * Returns 0 on successfully attached PM domain and when it found that the
> > - * device don't need a PM domain, else a negative error code.
> > + * Returns 0 on successfully attached PM domain, or when it is found that the
> > + * device doesn't need a PM domain, else a negative error code.
> >   */
> >  int dev_pm_domain_attach(struct device *dev, bool power_on)
> >  {
> > --

Applied, thanks!
diff mbox

Patch

diff --git a/drivers/base/power/common.c b/drivers/base/power/common.c
index 390868c2b392d57d..7ae62b6355b8d9ce 100644
--- a/drivers/base/power/common.c
+++ b/drivers/base/power/common.c
@@ -98,8 +98,8 @@  EXPORT_SYMBOL_GPL(dev_pm_put_subsys_data);
  * Callers must ensure proper synchronization of this function with power
  * management callbacks.
  *
- * Returns 0 on successfully attached PM domain and when it found that the
- * device don't need a PM domain, else a negative error code.
+ * Returns 0 on successfully attached PM domain, or when it is found that the
+ * device doesn't need a PM domain, else a negative error code.
  */
 int dev_pm_domain_attach(struct device *dev, bool power_on)
 {