| Message ID | 1537866192-12320-11-git-send-email-daniel.lezcano@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Eduardo Valentin |
| Headers | show |
| Series | thermal/drivers/hi3660: Dual cluster sensors support | expand |
On Tue, Sep 25, 2018 at 11:03:08AM +0200, Daniel Lezcano wrote: > Add the missing interrupts for the temperature sensors as well as > their names. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > Documentation/devicetree/bindings/thermal/hisilicon-thermal.txt | 8 ++++++-- Combine this and the previous binding change to 1 patch. > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 8 ++++++-- > 2 files changed, 12 insertions(+), 4 deletions(-) And more checkpatch whitespace errors in this.
On 15/10/2018 18:31, Rob Herring wrote: > On Tue, Sep 25, 2018 at 11:03:08AM +0200, Daniel Lezcano wrote: >> Add the missing interrupts for the temperature sensors as well as >> their names. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> --- >> Documentation/devicetree/bindings/thermal/hisilicon-thermal.txt | 8 ++++++-- > > Combine this and the previous binding change to 1 patch. Ok. >> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 8 ++++++-- >> 2 files changed, 12 insertions(+), 4 deletions(-) > > And more checkpatch whitespace errors in this. >
diff --git a/Documentation/devicetree/bindings/thermal/hisilicon-thermal.txt b/Documentation/devicetree/bindings/thermal/hisilicon-thermal.txt index 3edfae3..4cb8add 100644 --- a/Documentation/devicetree/bindings/thermal/hisilicon-thermal.txt +++ b/Documentation/devicetree/bindings/thermal/hisilicon-thermal.txt @@ -29,7 +29,11 @@ for Hi3660: tsensor: tsensor@fff30000 { compatible = "hisilicon,hi3660-tsensor"; reg = <0x0 0xfff30000 0x0 0x1000>; - interrupts = <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "tsensor_a73"; + interrupts = <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "tsensor_a73", "tsensor_a53", + "tsensor_g3d", "tsensor_modem"; #thermal-sensor-cells = <1>; }; diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi index bf8a479..dd398cb 100644 --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi @@ -1080,8 +1080,12 @@ tsensor: tsensor@fff30000 { compatible = "hisilicon,hi3660-tsensor"; reg = <0x0 0xfff30000 0x0 0x1000>; - interrupts = <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "tsensor_a73"; + interrupts = <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "tsensor_a73", "tsensor_a53", + "tsensor_g3d", "tsensor_modem"; #thermal-sensor-cells = <1>; };
Add the missing interrupts for the temperature sensors as well as their names. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- Documentation/devicetree/bindings/thermal/hisilicon-thermal.txt | 8 ++++++-- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-)