| Message ID | 1540912500-21941-3-git-send-email-Julia.Lawall@lip6.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Eduardo Valentin |
| Headers | show |
| Series | constify thermal_zone_of_device_ops structures | expand |
On 30/10/2018 16:15, Julia Lawall wrote: > The thermal_zone_of_device_ops structure can be const as it is only > passed as the last argument of thermal_zone_of_sensor_register > and the corresponding parameter is declared as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > > Unrelated to this change, is there a reason not to use > devm_thermal_zone_of_sensor_register? Agree, it would make sense to use the devm* version. > drivers/thermal/broadcom/brcmstb_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c > --- a/drivers/thermal/broadcom/brcmstb_thermal.c > +++ b/drivers/thermal/broadcom/brcmstb_thermal.c > @@ -299,7 +299,7 @@ static int brcmstb_set_trips(void *data, > return 0; > } > > -static struct thermal_zone_of_device_ops of_ops = { > +static const struct thermal_zone_of_device_ops of_ops = { > .get_temp = brcmstb_get_temp, > .set_trips = brcmstb_set_trips, > }; >
diff -u -p a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c --- a/drivers/thermal/broadcom/brcmstb_thermal.c +++ b/drivers/thermal/broadcom/brcmstb_thermal.c @@ -299,7 +299,7 @@ static int brcmstb_set_trips(void *data, return 0; } -static struct thermal_zone_of_device_ops of_ops = { +static const struct thermal_zone_of_device_ops of_ops = { .get_temp = brcmstb_get_temp, .set_trips = brcmstb_set_trips, };
The thermal_zone_of_device_ops structure can be const as it is only passed as the last argument of thermal_zone_of_sensor_register and the corresponding parameter is declared as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- Unrelated to this change, is there a reason not to use devm_thermal_zone_of_sensor_register? drivers/thermal/broadcom/brcmstb_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)