From patchwork Wed Feb 4 13:48:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 5776511 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A802C9F336 for ; Wed, 4 Feb 2015 13:25:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 641932025A for ; Wed, 4 Feb 2015 13:25:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BB0B201D3 for ; Wed, 4 Feb 2015 13:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755168AbbBDNZK (ORCPT ); Wed, 4 Feb 2015 08:25:10 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:62889 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754884AbbBDNZJ (ORCPT ); Wed, 4 Feb 2015 08:25:09 -0500 Received: from aeqy8.neoplus.adsl.tpnet.pl (79.191.180.8) (HELO vostro.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer v0.80) id 9f0b91d997d55213; Wed, 4 Feb 2015 14:25:08 +0100 From: "Rafael J. Wysocki" To: Cristian , Ashwin Chaugule Cc: linux-acpi@vger.kernel.org, Linux PM list Subject: Re: ACPI PCC probe failed. Date: Wed, 04 Feb 2015 14:48:02 +0100 Message-ID: <158128306.gX9FjqECDu@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <3337572.5q6DLI5fhi@vostro.rjw.lan> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday, February 03, 2015 09:44:36 PM Cristian wrote: > 2015-02-03 12:11 GMT-03:00 Rafael J. Wysocki : > > On Tuesday, February 03, 2015 10:40:00 AM Cristian wrote: > >> Hello, > >> > >> linux 3.19-rc7 > >> Ubuntu Vivid 14.04 alpha > >> > >> dmesg: > >> [ 1.293820] ACPI PCC probe failed. > >> > >> https://bugzilla.kernel.org/show_bug.cgi?id=92551 > > > > Is that a functional problem or just the message? > > > > > > -- > > I speak only for myself. > > Rafael J. Wysocki, Intel Open Source Technology Center. > > Apparently one message. So it looks like you build the PCC mailbox driver which is new in 3.19-rc and that driver fails to load, because it doesn't find hardware to work with. The message is harmless, but it also is not useful. The driver in question seems to be overly verbose to me in general. The patch below should make the message go away unless the printing of debug messages is on. Ashwin, that whole thing requires cleaning up: - It prints uninteresting debug messages with KERN_ERR or warning priority in *many* places. - The error codes from acpi_pcc_probe() are ignored, so why bother to return any error codes from there? - If platform_create_bundle() fails, the debug message doesn't tell us the reason, so why bother to print it? I'm not going to consider any users of this for merging before that cleanup happens. Rafael --- drivers/mailbox/pcc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-pm/drivers/mailbox/pcc.c =================================================================== --- linux-pm.orig/drivers/mailbox/pcc.c +++ linux-pm/drivers/mailbox/pcc.c @@ -386,7 +386,7 @@ static int __init pcc_init(void) ret = acpi_pcc_probe(); if (ret) { - pr_err("ACPI PCC probe failed.\n"); + pr_debug("ACPI PCC probe failed.\n"); return -ENODEV; } @@ -394,7 +394,7 @@ static int __init pcc_init(void) pcc_mbox_probe, NULL, 0, NULL, 0); if (!pcc_pdev) { - pr_err("Err creating PCC platform bundle\n"); + pr_debug("Err creating PCC platform bundle\n"); return -ENODEV; }