diff mbox series

[RESEND,V3] PM / EM: Micro optimization in em_cpu_energy

Message ID 1606527564-27238-1-git-send-email-pkondeti@codeaurora.org (mailing list archive)
State Mainlined, archived
Headers show
Series [RESEND,V3] PM / EM: Micro optimization in em_cpu_energy | expand

Commit Message

Pavan Kondeti Nov. 28, 2020, 1:39 a.m. UTC 
When the sum of the utilization of CPUs in a power domain is zero,
return the energy as 0 without doing any computations.

Acked-by: Quentin Perret <qperret@google.com>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
---
 include/linux/energy_model.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rafael J. Wysocki Dec. 8, 2020, 5:24 p.m. UTC | #1 
On Sat, Nov 28, 2020 at 3:21 AM Pavankumar Kondeti
<pkondeti@codeaurora.org> wrote:
>
> When the sum of the utilization of CPUs in a power domain is zero,
> return the energy as 0 without doing any computations.
>
> Acked-by: Quentin Perret <qperret@google.com>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
> ---
>  include/linux/energy_model.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
> index b67a51c..8810f1f 100644
> --- a/include/linux/energy_model.h
> +++ b/include/linux/energy_model.h
> @@ -103,6 +103,9 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
>         struct em_perf_state *ps;
>         int i, cpu;
>
> +       if (!sum_util)
> +               return 0;
> +
>         /*
>          * In order to predict the performance state, map the utilization of
>          * the most utilized CPU of the performance domain to a requested
> --

Applied as 5.11 material, thanks!
diff mbox series

Patch

diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
index b67a51c..8810f1f 100644
--- a/include/linux/energy_model.h
+++ b/include/linux/energy_model.h
@@ -103,6 +103,9 @@  static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
 	struct em_perf_state *ps;
 	int i, cpu;
 
+	if (!sum_util)
+		return 0;
+
 	/*
 	 * In order to predict the performance state, map the utilization of
 	 * the most utilized CPU of the performance domain to a requested