diff mbox series

[v1] cpufreq: qcom-hw: Set dvfs_possible_from_any_cpu cpufreq driver flag

Message ID 1628645918-12890-1-git-send-email-tdas@codeaurora.org (mailing list archive)
State New, archived
Delegated to: viresh kumar
Headers show
Series [v1] cpufreq: qcom-hw: Set dvfs_possible_from_any_cpu cpufreq driver flag | expand

Commit Message

Taniya Das Aug. 11, 2021, 1:38 a.m. UTC
As remote cpufreq updates are supported on QCOM platforms, set
dvfs_possible_from_any_cpu cpufreq driver flag.

Signed-off-by: Taniya Das <tdas@codeaurora.org>
---
 drivers/cpufreq/qcom-cpufreq-hw.c | 1 +
 1 file changed, 1 insertion(+)

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the  Linux Foundation.

Comments

Viresh Kumar Aug. 11, 2021, 3:57 a.m. UTC | #1
On 11-08-21, 07:08, Taniya Das wrote:
> As remote cpufreq updates are supported on QCOM platforms, set
> dvfs_possible_from_any_cpu cpufreq driver flag.
> 
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
>  drivers/cpufreq/qcom-cpufreq-hw.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
> index f86859b..20455aa 100644
> --- a/drivers/cpufreq/qcom-cpufreq-hw.c
> +++ b/drivers/cpufreq/qcom-cpufreq-hw.c
> @@ -161,6 +161,7 @@ static int qcom_cpufreq_hw_read_lut(struct device *cpu_dev,
>  		return ret;
>  	} else {
>  		policy->fast_switch_possible = true;
> +		policy->dvfs_possible_from_any_cpu = true;
>  		icc_scaling_enabled = false;
>  	}

Why don't you set it always ?

> 
> --
> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
> of the Code Aurora Forum, hosted by the  Linux Foundation.
Taniya Das Aug. 12, 2021, 7:51 a.m. UTC | #2
Thanks Viresh for the review.

On 8/11/2021 9:27 AM, Viresh Kumar wrote:
> On 11-08-21, 07:08, Taniya Das wrote:
>> As remote cpufreq updates are supported on QCOM platforms, set
>> dvfs_possible_from_any_cpu cpufreq driver flag.
>>
>> Signed-off-by: Taniya Das <tdas@codeaurora.org>
>> ---
>>   drivers/cpufreq/qcom-cpufreq-hw.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
>> index f86859b..20455aa 100644
>> --- a/drivers/cpufreq/qcom-cpufreq-hw.c
>> +++ b/drivers/cpufreq/qcom-cpufreq-hw.c
>> @@ -161,6 +161,7 @@ static int qcom_cpufreq_hw_read_lut(struct device *cpu_dev,
>>   		return ret;
>>   	} else {
>>   		policy->fast_switch_possible = true;
>> +		policy->dvfs_possible_from_any_cpu = true;
>>   		icc_scaling_enabled = false;
>>   	}
> 
> Why don't you set it always ?
> 

Sure, will move it outside.
>>
>> --
>> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
>> of the Code Aurora Forum, hosted by the  Linux Foundation.
>
diff mbox series

Patch

diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
index f86859b..20455aa 100644
--- a/drivers/cpufreq/qcom-cpufreq-hw.c
+++ b/drivers/cpufreq/qcom-cpufreq-hw.c
@@ -161,6 +161,7 @@  static int qcom_cpufreq_hw_read_lut(struct device *cpu_dev,
 		return ret;
 	} else {
 		policy->fast_switch_possible = true;
+		policy->dvfs_possible_from_any_cpu = true;
 		icc_scaling_enabled = false;
 	}