| Message ID | 171568193292.10875.138258500319101503.tip-bot2@tip-bot2 (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [thermal:,thermal/fixes] dt-bindings: thermal: loongson,ls2k-thermal: Fix incorrect compatible definition | expand |
diff --git a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml index 9748a47..ca81c8a 100644 --- a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml @@ -18,14 +18,15 @@ properties: oneOf: - enum: - loongson,ls2k1000-thermal + - loongson,ls2k2000-thermal - items: - enum: - loongson,ls2k0500-thermal - - loongson,ls2k2000-thermal - const: loongson,ls2k1000-thermal reg: - maxItems: 1 + minItems: 1 + maxItems: 2 interrupts: maxItems: 1 @@ -39,6 +40,24 @@ required: - interrupts - '#thermal-sensor-cells' +if: + properties: + compatible: + contains: + enum: + - loongson,ls2k2000-thermal + +then: + properties: + reg: + minItems: 2 + maxItems: 2 + +else: + properties: + reg: + maxItems: 1 + unevaluatedProperties: false examples:
The following commit has been merged into the thermal/fixes branch of thermal: Commit-ID: c8c4353685778e75e186103411e9d01a4a3f2b90 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//c8c4353685778e75e186103411e9d01a4a3f2b90 Author: Binbin Zhou <zhoubinbin@loongson.cn> AuthorDate: Tue, 23 Apr 2024 09:59:02 +08:00 Committer: Daniel Lezcano <daniel.lezcano@linaro.org> CommitterDate: Tue, 23 Apr 2024 12:40:30 +02:00 dt-bindings: thermal: loongson,ls2k-thermal: Fix incorrect compatible definition The temperature output register of the Loongson-2K2000 is defined in the chip configuration domain, which is different from the Loongson-2K1000, so it can't be fallbacked. We need to use two groups of registers to describe it: the first group is the high and low temperature threshold setting register; the second group is the temperature output register. It is true that this fix will cause ABI corruption, but it is necessary otherwise the Loongson-2K2000 temperature sensor will not work properly. Fixes: 72684d99a854 ("thermal: dt-bindings: add loongson-2 thermal") Cc: Yinbo Zhu <zhuyinbo@loongson.cn> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Huacai Chen <chenhuacai@loongson.cn> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/5198999d679f1a1c3457385acb9fadfc85da1f1e.1713837379.git.zhoubinbin@loongson.cn --- Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-)