| Message ID | 1bf82454ab1f16b13212548d7c9605067c8b7a0d.1359700705.git.viresh.kumar@linaro.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 1 February 2013 12:10, Viresh Kumar <viresh.kumar@linaro.org> wrote: > For multicore SoC's, with cores sharing clock line, we are required to set > policy->cpus and policy->related_cpus with mask of cpus. > > With following patch, we need to set policy->cpus with mask of all possible cpus > and policy->related_cpus would be filled automatically by the cpufreq core. > > commit 4948b355e90080cd5ec1e91189f65a01e4186ef2 > Author: Viresh Kumar <viresh.kumar@linaro.org> > Date: Tue Jan 29 14:39:08 2013 +0000 > > cpufreq: Simplify cpufreq_add_dev() > > Current Tegra driver fills only ->related_cpus and not ->cpus, which looks to be > incorrect. Lets fix it. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Stephen Warren <swarren@nvidia.com> ARM mail servers are broken, please find patch attached.
On 01/31/2013 11:40 PM, Viresh Kumar wrote: > For multicore SoC's, with cores sharing clock line, we are required to set > policy->cpus and policy->related_cpus with mask of cpus. > > With following patch, we need to set policy->cpus with mask of all possible cpus > and policy->related_cpus would be filled automatically by the cpufreq core. > > commit 4948b355e90080cd5ec1e91189f65a01e4186ef2 > Author: Viresh Kumar <viresh.kumar@linaro.org> > Date: Tue Jan 29 14:39:08 2013 +0000 > > cpufreq: Simplify cpufreq_add_dev() > > Current Tegra driver fills only ->related_cpus and not ->cpus, which looks to be > incorrect. Lets fix it. Joseph Lo reviewed/tested this and it looks fine, so, Acked-by: Stephen Warren <swarren@nvidia.com> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-tegra/cpu-tegra.c b/arch/arm/mach-tegra/cpu-tegra.c index a74d3c7..e7ddcb2 100644 --- a/arch/arm/mach-tegra/cpu-tegra.c +++ b/arch/arm/mach-tegra/cpu-tegra.c @@ -244,7 +244,7 @@ static int tegra_cpu_init(struct cpufreq_policy *policy) policy->cpuinfo.transition_latency = 300 * 1000; policy->shared_type = CPUFREQ_SHARED_TYPE_ALL; - cpumask_copy(policy->related_cpus, cpu_possible_mask); + cpumask_copy(policy->cpus, cpu_possible_mask); if (policy->cpu == 0) register_pm_notifier(&tegra_cpu_pm_notifier);
For multicore SoC's, with cores sharing clock line, we are required to set policy->cpus and policy->related_cpus with mask of cpus. With following patch, we need to set policy->cpus with mask of all possible cpus and policy->related_cpus would be filled automatically by the cpufreq core. commit 4948b355e90080cd5ec1e91189f65a01e4186ef2 Author: Viresh Kumar <viresh.kumar@linaro.org> Date: Tue Jan 29 14:39:08 2013 +0000 cpufreq: Simplify cpufreq_add_dev() Current Tegra driver fills only ->related_cpus and not ->cpus, which looks to be incorrect. Lets fix it. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Cc: Stephen Warren <swarren@nvidia.com> --- arch/arm/mach-tegra/cpu-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)