From patchwork Fri Sep 7 02:58:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 1418831 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 5313CDFFCF for ; Fri, 7 Sep 2012 02:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932133Ab2IGC6h (ORCPT ); Thu, 6 Sep 2012 22:58:37 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:65312 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757845Ab2IGC6g (ORCPT ); Thu, 6 Sep 2012 22:58:36 -0400 Received: by pbbrr13 with SMTP id rr13so3383422pbb.19 for ; Thu, 06 Sep 2012 19:58:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :x-gm-message-state; bh=aDdmIEpyCRXJH4Wpz7/5581zLxvSLAqbuUQ2TPUJrfw=; b=RXDheMFG1m+P/bnz6VSPjCPdd2d6fqkCUQtr0qPHzkXPDPXIm2RcmOgO7t51a7Yw4U myTApga84XFZZ24p0w7ej27a1JyzPw7bjd2ev9rm8V0r0M9ETw5GYTV2R1gbweQlej/z MnQ6VWubDgZWHwp0/n3W//TwfejMTnG34cN4EEU1bh3wbPJ+gc1N40rMFkPdOGQBsKz2 8oMT7aYhTn0LSkJUjdmNyIB+BiPhFWiYu0ec/gF/zwTRxkPOHen/wKahZBWJf0QVd/UB pvvv/xbFB6GCvUKafJX2Db2H3yu/GMCAwf/G1EDuUUIKPcj/3BD+FuXhothUqyh5M6Dd 3lQw== Received: by 10.66.79.36 with SMTP id g4mr6453069pax.67.1346986715947; Thu, 06 Sep 2012 19:58:35 -0700 (PDT) Received: from S2101-09.ap.freescale.net ([221.225.141.144]) by mx.google.com with ESMTPS id qo8sm2373072pbb.19.2012.09.06.19.58.31 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Sep 2012 19:58:35 -0700 (PDT) Date: Fri, 7 Sep 2012 10:58:49 +0800 From: Shawn Guo To: Stephen Warren Cc: "Rafael J. Wysocki" , Kevin Hilman , Nishanth Menon , Mike Turquette , Russell King - ARM Linux , linux-pm@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Mark Brown , cpufreq@vger.kernel.org, Shilimkar Santosh , Rob Herring , Richard Zhao , Richard Zhao , linux-arm-kernel@lists.infradead.org, "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v3 1/3] ARM: add cpufreq transiton notifier to adjust loops_per_jiffy for smp Message-ID: <20120907025847.GI26709@S2101-09.ap.freescale.net> References: <1344577046-14847-1-git-send-email-shawn.guo@linaro.org> <1344577046-14847-2-git-send-email-shawn.guo@linaro.org> <5049252D.9000802@wwwdotorg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5049252D.9000802@wwwdotorg.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQmDQbw7VIYN5PXQPeSUpaMqEklsZcnVfutKYeYJviKudpd9ruyz1LULIXlbi8OR3vu22SZM Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Sep 06, 2012 at 04:35:25PM -0600, Stephen Warren wrote: > I believe this patch is causing issues initializing PCI-Express on Tegra. > > In next-20120906, I cold-booted 10 times. 3 times, PCIe initialized OK, > and 7 times, the driver timed out in arch/arm/mach-tegra/pcie.c function > tegra_pcie_check_link(). With this patch reverted, another 10 cold boot > attempts all succeeded just fine. Similarly, the regression appeared in > next-20120905, and I isolated it to arch/arm/kernel/, and this is the > only patch in that directory between next-20120904 and next-20120905. > > Do you have any idea what the problem might be? > > Looking at the timestamps in dmesg in the failing case, the driver is > waiting the expected (per pcie.c driver code) 1.2 seconds before giving > up on the port, although I suppose if the kernel's idea of real-time is > off, then the dmesg log timestamps might be off too. Just for identifying the problem, can you test the following change to see if it fixes the failure. Regards, Shawn --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/mach-tegra/cpu-tegra.c b/arch/arm/mach-tegra/cpu-tegra.c index ceb52db..a3bbdc9 100644 --- a/arch/arm/mach-tegra/cpu-tegra.c +++ b/arch/arm/mach-tegra/cpu-tegra.c @@ -247,5 +247,5 @@ static void __exit tegra_cpufreq_exit(void) MODULE_AUTHOR("Colin Cross "); MODULE_DESCRIPTION("cpufreq driver for Nvidia Tegra2"); MODULE_LICENSE("GPL"); -module_init(tegra_cpufreq_init); +late_init(tegra_cpufreq_init); module_exit(tegra_cpufreq_exit);