drivers/cpuidle/governors/menu.c:268:2: warning: comparison of distinct pointer types lacks a cast

Commit Message

Fengguang Wu Oct. 23, 2012, 12:44 p.m. UTC

Youquan,

On Tue, Oct 23, 2012 at 07:23:00PM +0800, Song, Youquan wrote:
> Hi Fengguang,
> 
> Sorry. I built the kernel at 32bit OS RHEL6 i686 without any complain about it.
> Are you built it for sh architecture? by "make ARCH=sh sh7785lcr_32bit_defconfig", I do not know this architecture at all. Who can help me on it?

No worry. This is tested to remove the following warnings.

drivers/cpuidle/governors/menu.c: In function 'get_typical_interval':
drivers/cpuidle/governors/menu.c:268:2: warning: comparison of distinct pointer types lacks a cast [enabled by default]
drivers/cpuidle/governors/menu.c:277:2: warning: comparison of distinct pointer types lacks a cast [enabled by default]

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
index 26d5667..2efee27 100644
--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -248,7 +248,7 @@  static enum hrtimer_restart menu_hrtimer_notify(struct hrtimer *hrtimer)
 static u32 get_typical_interval(struct menu_device *data)
 {
 	int i = 0, divisor = 0;
-	int64_t max = 0, avg = 0, stddev = 0;
+	uint64_t max = 0, avg = 0, stddev = 0;
 	int64_t thresh = LLONG_MAX; /* Discard outliers above this value. */
 	unsigned int ret = 0;