From patchwork Fri Jan 11 14:03:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fengguang Wu X-Patchwork-Id: 1966291 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 9ACC53FE37 for ; Fri, 11 Jan 2013 14:03:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752409Ab3AKODL (ORCPT ); Fri, 11 Jan 2013 09:03:11 -0500 Received: from mga11.intel.com ([192.55.52.93]:35882 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816Ab3AKODK (ORCPT ); Fri, 11 Jan 2013 09:03:10 -0500 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 11 Jan 2013 06:03:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,451,1355126400"; d="diff'?scan'208";a="272710456" Received: from unknown (HELO wfg-t420.sh.intel.com) ([10.255.21.241]) by fmsmga001.fm.intel.com with ESMTP; 11 Jan 2013 06:03:04 -0800 Received: from wfg by wfg-t420.sh.intel.com with local (Exim 4.77) (envelope-from ) id 1TtfCH-0006eC-Gg; Fri, 11 Jan 2013 22:03:01 +0800 Date: Fri, 11 Jan 2013 22:03:01 +0800 From: Fengguang Wu To: Viresh Kumar Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org Subject: drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? Message-ID: <20130111140301.GA25489@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <50f017f7.SoVcNexmm6uNvfQX%yuanhan.liu@linux.intel.com> User-Agent: Heirloom mailx 12.5 6/20/10 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Viresh, FYI, there are new sparse warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next head: f3bb59ab652c781155b1c5e42ef7e29bf936d86b commit: 536ff06aba714c1d2d53cfca86b1a2e455842387 cpufreq: Don't use cpu removed during cpufreq_driver_unregister date: 15 hours ago drivers/cpufreq/cpufreq.c:43:8: sparse: symbol 'cpufreq_cpu_data' was not declared. Should it be static? drivers/cpufreq/cpufreq.c:46:8: sparse: symbol 'cpufreq_cpu_governor' was not declared. Should it be static? >> drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? drivers/cpufreq/cpufreq.c:72:8: sparse: symbol 'cpufreq_policy_cpu' was not declared. Should it be static? drivers/cpufreq/cpufreq.c:73:8: sparse: symbol 'cpu_policy_rwsem' was not declared. Should it be static? Please consider folding the attached diff :-) --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 271d3be..26dbf40 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -48,7 +48,7 @@ static DEFINE_PER_CPU(char[CPUFREQ_NAME_LEN], cpufreq_cpu_governor); static DEFINE_SPINLOCK(cpufreq_driver_lock); /* Used when we unregister cpufreq driver */ -struct cpumask cpufreq_online_mask; +static struct cpumask cpufreq_online_mask; /* * cpu_policy_rwsem is a per CPU reader-writer semaphore designed to cure