From patchwork Wed Sep 25 23:17:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Srivatsa S. Bhat" X-Patchwork-Id: 2945351 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CE937BFF05 for ; Wed, 25 Sep 2013 23:21:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0BD5D20207 for ; Wed, 25 Sep 2013 23:21:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DF212037D for ; Wed, 25 Sep 2013 23:21:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755871Ab3IYXVf (ORCPT ); Wed, 25 Sep 2013 19:21:35 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:50012 "EHLO e23smtp06.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755033Ab3IYXVd (ORCPT ); Wed, 25 Sep 2013 19:21:33 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Sep 2013 09:21:32 +1000 Received: from d23dlp03.au.ibm.com (202.81.31.214) by e23smtp06.au.ibm.com (202.81.31.212) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 26 Sep 2013 09:21:29 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 534DD3578054; Thu, 26 Sep 2013 09:21:29 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8PN4d6567043492; Thu, 26 Sep 2013 09:04:39 +1000 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r8PNLQ1W020831; Thu, 26 Sep 2013 09:21:28 +1000 Received: from srivatsabhat.in.ibm.com ([9.79.250.85]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r8PNLIJu020706; Thu, 26 Sep 2013 09:21:19 +1000 From: "Srivatsa S. Bhat" Subject: [RFC PATCH v4 15/40] mm: Add aggressive bias to prefer lower regions during page allocation To: akpm@linux-foundation.org, mgorman@suse.de, dave@sr71.net, hannes@cmpxchg.org, tony.luck@intel.com, matthew.garrett@nebula.com, riel@redhat.com, arjan@linux.intel.com, srinivas.pandruvada@linux.intel.com, willy@linux.intel.com, kamezawa.hiroyu@jp.fujitsu.com, lenb@kernel.org, rjw@sisk.pl Cc: gargankita@gmail.com, paulmck@linux.vnet.ibm.com, svaidy@linux.vnet.ibm.com, andi@firstfloor.org, isimatu.yasuaki@jp.fujitsu.com, santosh.shilimkar@ti.com, kosaki.motohiro@gmail.com, srivatsa.bhat@linux.vnet.ibm.com, linux-pm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Thu, 26 Sep 2013 04:47:16 +0530 Message-ID: <20130925231714.26184.93687.stgit@srivatsabhat.in.ibm.com> In-Reply-To: <20130925231250.26184.31438.stgit@srivatsabhat.in.ibm.com> References: <20130925231250.26184.31438.stgit@srivatsabhat.in.ibm.com> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13092523-7014-0000-0000-000003AB4F0B Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,KHOP_BIG_TO_CC, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP While allocating pages from buddy freelists, there could be situations in which we have a ready freepage of the required order in a *higher* numbered memory region, and there also exists a freepage of a higher page order in a *lower* numbered memory region. To make the consolidation logic more aggressive, try to split up the higher order buddy page of a lower numbered region and allocate it, rather than allocating pages from a higher numbered region. This ensures that we spill over to a new region only when we truly don't have enough contiguous memory in any lower numbered region to satisfy that allocation request. Signed-off-by: Srivatsa S. Bhat --- mm/page_alloc.c | 44 ++++++++++++++++++++++++++++++++++---------- 1 file changed, 34 insertions(+), 10 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/mm/page_alloc.c b/mm/page_alloc.c index fbaa2dc..dc02a80 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1211,8 +1211,9 @@ static inline struct page *__rmqueue_smallest(struct zone *zone, unsigned int order, int migratetype) { - unsigned int current_order; - struct free_area *area; + unsigned int current_order, alloc_order; + struct free_area *area, *other_area; + int alloc_region, other_region; struct page *page; /* Find a page of the appropriate size in the preferred list */ @@ -1221,17 +1222,40 @@ struct page *__rmqueue_smallest(struct zone *zone, unsigned int order, if (list_empty(&area->free_list[migratetype].list)) continue; - page = list_entry(area->free_list[migratetype].list.next, - struct page, lru); - rmqueue_del_from_freelist(page, &area->free_list[migratetype], - current_order); - rmv_page_order(page); - area->nr_free--; - expand(zone, page, order, current_order, area, migratetype); - return page; + alloc_order = current_order; + alloc_region = area->free_list[migratetype].next_region - + area->free_list[migratetype].mr_list; + current_order++; + goto try_others; } return NULL; + +try_others: + /* Try to aggressively prefer lower numbered regions for allocations */ + for ( ; current_order < MAX_ORDER; ++current_order) { + other_area = &(zone->free_area[current_order]); + if (list_empty(&other_area->free_list[migratetype].list)) + continue; + + other_region = other_area->free_list[migratetype].next_region - + other_area->free_list[migratetype].mr_list; + + if (other_region < alloc_region) { + alloc_region = other_region; + alloc_order = current_order; + } + } + + area = &(zone->free_area[alloc_order]); + page = list_entry(area->free_list[migratetype].list.next, struct page, + lru); + rmqueue_del_from_freelist(page, &area->free_list[migratetype], + alloc_order); + rmv_page_order(page); + area->nr_free--; + expand(zone, page, order, alloc_order, area, migratetype); + return page; }