| Message ID | 20150224141732.5c937402@notabene.brown (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi, On Tue, Feb 24, 2015 at 02:17:32PM +1100, NeilBrown wrote: > power_supply status changes for the bq27x00 are only noticed via > polling, not via interrupts. So they are never the source of > events which should reliably wake the system from suspend. So it > is appropriate to register as a no_ws power source, just like the > ACPI battery. > > This removes some debugging messages which occasionally > confusingly identify bq27x00 as a wakeup source. > > Signed-off-by: NeilBrown <neilb@suse.de> pulled into battery-2.6.git. -- Sebastian
diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c index b72ba7c1bd69..93d2b7f910f1 100644 --- a/drivers/power/bq27x00_battery.c +++ b/drivers/power/bq27x00_battery.c @@ -755,7 +755,7 @@ static int bq27x00_powersupply_init(struct bq27x00_device_info *di) INIT_DELAYED_WORK(&di->work, bq27x00_battery_poll); mutex_init(&di->lock); - ret = power_supply_register(di->dev, &di->bat); + ret = power_supply_register_no_ws(di->dev, &di->bat); if (ret) { dev_err(di->dev, "failed to register battery: %d\n", ret); return ret;
power_supply status changes for the bq27x00 are only noticed via polling, not via interrupts. So they are never the source of events which should reliably wake the system from suspend. So it is appropriate to register as a no_ws power source, just like the ACPI battery. This removes some debugging messages which occasionally confusingly identify bq27x00 as a wakeup source. Signed-off-by: NeilBrown <neilb@suse.de>