| Message ID | 20160214052228.GA18226@vireshk-i7 (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
W dniu 14.02.2016 o 14:22, Viresh Kumar pisze: > On 14-02-16, 13:56, Krzysztof Kozlowski wrote: >> Hi all, >> >> Recently Odroid XU3 failed to boot on linux-next >> on multi_v7 defconfig. exynos defconfig boots fine. >> >> Probably the "cpufreq: dt: Use dev_pm_opp_set_rate() to >> switch frequency" is important here: >> commit 78c3ba5df96c875b1668e1cd3ee0a69e62454f32 >> Author: Viresh Kumar <viresh.kumar@linaro.org> >> Date: Tue Feb 9 10:30:46 2016 +0530 >> >> cpufreq: dt: Use dev_pm_opp_set_rate() to switch frequency >> >> OPP core supports frequency/voltage changes based on the target >> frequency now, use that instead of open coding the same in cpufreq-dt >> driver. >> >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> >> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> >> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Can you please try the below untested patch please ? Thanks for quick reply. The patch fixed the problem. Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof > diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c > index d7cd4e265766..a97b333036c9 100644 > --- a/drivers/base/power/opp/core.c > +++ b/drivers/base/power/opp/core.c > @@ -1156,9 +1156,15 @@ static int opp_parse_supplies(struct dev_pm_opp *opp, struct device *dev, > return -EINVAL; > } > > - opp->u_volt = microvolt[0]; > - opp->u_volt_min = microvolt[1]; > - opp->u_volt_max = microvolt[2]; > + if (count == 1) { > + opp->u_volt = microvolt[0]; > + opp->u_volt_min = opp->u_volt; > + opp->u_volt_max = opp->u_volt; > + } else { > + opp->u_volt = microvolt[0]; > + opp->u_volt_min = microvolt[1]; > + opp->u_volt_max = microvolt[2]; > + } > > /* Search for "opp-microamp-<name>" */ > prop = NULL; > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c index d7cd4e265766..a97b333036c9 100644 --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -1156,9 +1156,15 @@ static int opp_parse_supplies(struct dev_pm_opp *opp, struct device *dev, return -EINVAL; } - opp->u_volt = microvolt[0]; - opp->u_volt_min = microvolt[1]; - opp->u_volt_max = microvolt[2]; + if (count == 1) { + opp->u_volt = microvolt[0]; + opp->u_volt_min = opp->u_volt; + opp->u_volt_max = opp->u_volt; + } else { + opp->u_volt = microvolt[0]; + opp->u_volt_min = microvolt[1]; + opp->u_volt_max = microvolt[2]; + } /* Search for "opp-microamp-<name>" */ prop = NULL;