diff mbox

power: ipaq-micro-battery: freeing the wrong variable

Message ID 20160318090051.GA19233@mwanda (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Dan Carpenter March 18, 2016, 9 a.m. UTC
We accidentally free "micro_ac_power" which is an error pointer and it
leads to an oops.  We intended to free "micro_batt_power".

Fixes: a2c1d531854c ('power_supply: ipaq_micro_battery: Check return values in probe')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Sebastian Reichel April 10, 2016, 4:27 p.m. UTC | #1
Hi,

On Fri, Mar 18, 2016 at 12:00:51PM +0300, Dan Carpenter wrote:
> We accidentally free "micro_ac_power" which is an error pointer and it
> leads to an oops.  We intended to free "micro_batt_power".

Thanks, queued.

-- Sebastian
diff mbox

Patch

diff --git a/drivers/power/ipaq_micro_battery.c b/drivers/power/ipaq_micro_battery.c
index 3f314b1..35b01c7 100644
--- a/drivers/power/ipaq_micro_battery.c
+++ b/drivers/power/ipaq_micro_battery.c
@@ -261,7 +261,7 @@  static int micro_batt_probe(struct platform_device *pdev)
 	return 0;
 
 ac_err:
-	power_supply_unregister(micro_ac_power);
+	power_supply_unregister(micro_batt_power);
 batt_err:
 	cancel_delayed_work_sync(&mb->update);
 	destroy_workqueue(mb->wq);