| Message ID | 20160704131318.990672-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
On 07/04/2016 06:42 PM, Arnd Bergmann wrote: > The newly added tsens-8916 driver produces warnings when CONFIG_PM > is disabled: > > drivers/thermal/qcom/tsens.c:53:12: error: 'tsens_resume' defined but not used [-Werror=unused-function] > static int tsens_resume(struct device *dev) > ^~~~~~~~~~~~ > drivers/thermal/qcom/tsens.c:43:12: error: 'tsens_suspend' defined but not used [-Werror=unused-function] > static int tsens_suspend(struct device *dev) > ^~~~~~~~~~~~~ > > This marks both functions __maybe_unused to let the compiler > know that they might be used in other configurations, without > adding ugly #ifdef logic. Thanks Arnd, Reviewed-by: Rajendra Nayak <rnayak@codeaurora.org> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/thermal/qcom/tsens.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index 446f70b5dbb2..e4fca3350d26 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -40,7 +40,7 @@ static int tsens_get_trend(void *p, int trip, enum thermal_trend *trend) > return -ENOTSUPP; > } > > -static int tsens_suspend(struct device *dev) > +static int __maybe_unused tsens_suspend(struct device *dev) > { > struct tsens_device *tmdev = dev_get_drvdata(dev); > > @@ -50,7 +50,7 @@ static int tsens_suspend(struct device *dev) > return 0; > } > > -static int tsens_resume(struct device *dev) > +static int __maybe_unused tsens_resume(struct device *dev) > { > struct tsens_device *tmdev = dev_get_drvdata(dev); > >
On 一, 2016-07-04 at 15:12 +0200, Arnd Bergmann wrote: > The newly added tsens-8916 driver produces warnings when CONFIG_PM > is disabled: > > drivers/thermal/qcom/tsens.c:53:12: error: 'tsens_resume' defined but > not used [-Werror=unused-function] > static int tsens_resume(struct device *dev) > ^~~~~~~~~~~~ > drivers/thermal/qcom/tsens.c:43:12: error: 'tsens_suspend' defined > but not used [-Werror=unused-function] > static int tsens_suspend(struct device *dev) > ^~~~~~~~~~~~~ > > This marks both functions __maybe_unused to let the compiler > know that they might be used in other configurations, without > adding ugly #ifdef logic. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Patch queued for 4.9, with a minor fix for the following checkpatch error, ERROR: "foo __maybe_unused bar" should be "foo __maybe_unused bar" #54: FILE: drivers/thermal/qcom/tsens.c:53: +static int __maybe_unused tsens_resume(struct device *dev) total: 1 errors, 0 warnings, 16 lines checked thanks, rui > --- > drivers/thermal/qcom/tsens.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens.c > b/drivers/thermal/qcom/tsens.c > index 446f70b5dbb2..e4fca3350d26 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -40,7 +40,7 @@ static int tsens_get_trend(void *p, int trip, enum > thermal_trend *trend) > return -ENOTSUPP; > } > > -static int tsens_suspend(struct device *dev) > +static int __maybe_unused tsens_suspend(struct device *dev) > { > struct tsens_device *tmdev = dev_get_drvdata(dev); > > @@ -50,7 +50,7 @@ static int tsens_suspend(struct device *dev) > return 0; > } > > -static int tsens_resume(struct device *dev) > +static int __maybe_unused tsens_resume(struct device *dev) > { > struct tsens_device *tmdev = dev_get_drvdata(dev); > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 446f70b5dbb2..e4fca3350d26 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -40,7 +40,7 @@ static int tsens_get_trend(void *p, int trip, enum thermal_trend *trend) return -ENOTSUPP; } -static int tsens_suspend(struct device *dev) +static int __maybe_unused tsens_suspend(struct device *dev) { struct tsens_device *tmdev = dev_get_drvdata(dev); @@ -50,7 +50,7 @@ static int tsens_suspend(struct device *dev) return 0; } -static int tsens_resume(struct device *dev) +static int __maybe_unused tsens_resume(struct device *dev) { struct tsens_device *tmdev = dev_get_drvdata(dev);
The newly added tsens-8916 driver produces warnings when CONFIG_PM is disabled: drivers/thermal/qcom/tsens.c:53:12: error: 'tsens_resume' defined but not used [-Werror=unused-function] static int tsens_resume(struct device *dev) ^~~~~~~~~~~~ drivers/thermal/qcom/tsens.c:43:12: error: 'tsens_suspend' defined but not used [-Werror=unused-function] static int tsens_suspend(struct device *dev) ^~~~~~~~~~~~~ This marks both functions __maybe_unused to let the compiler know that they might be used in other configurations, without adding ugly #ifdef logic. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/thermal/qcom/tsens.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)