| Message ID | 20161110125215.GA18664@mwanda (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Thu 2016-11-10 15:52:15, Dan Carpenter wrote: > The first argument of WARN() is the condition, followed by the message. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Pavel Machek <pavel@ucw.cz>
On 10 November 2016 at 13:52, Dan Carpenter <dan.carpenter@oracle.com> wrote: > The first argument of WARN() is the condition, followed by the message. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 661737c..7b4d41f 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd, > * powered on/off in that context. > */ > if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) { > - WARN("Parent %s of subdomain %s must be IRQ safe\n", > + WARN(1, "Parent %s of subdomain %s must be IRQ safe\n", > genpd->name, subdomain->name); > return -EINVAL; > } -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday, November 10, 2016 08:25:36 PM Ulf Hansson wrote: > On 10 November 2016 at 13:52, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > The first argument of WARN() is the condition, followed by the message. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Applied. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 661737c..7b4d41f 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd, * powered on/off in that context. */ if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) { - WARN("Parent %s of subdomain %s must be IRQ safe\n", + WARN(1, "Parent %s of subdomain %s must be IRQ safe\n", genpd->name, subdomain->name); return -EINVAL; }
The first argument of WARN() is the condition, followed by the message. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html