From patchwork Wed Jan 18 17:26:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liam Breck X-Patchwork-Id: 9524341 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8C69F60442 for ; Wed, 18 Jan 2017 17:28:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7CFFF2656B for ; Wed, 18 Jan 2017 17:28:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71C5F2860E; Wed, 18 Jan 2017 17:28:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20CCB285F9 for ; Wed, 18 Jan 2017 17:28:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990AbdARR2V (ORCPT ); Wed, 18 Jan 2017 12:28:21 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35693 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbdARR2Q (ORCPT ); Wed, 18 Jan 2017 12:28:16 -0500 Received: by mail-pf0-f196.google.com with SMTP id f144so1514126pfa.2 for ; Wed, 18 Jan 2017 09:28:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=mmlaDMLTqQCoVwWxbD+B5T02aWWKiBqosdz5bFfwjM4=; b=jKpISdsDhJ16yi9/3OVx3OL5yMSsCFWYM8FsVyHVroSrlOdLeZMx+Wn3crjdumnJci p/lUeO0WnSZKw++adxl+Xl/h+i3eRCITOHujU+RBh0+SS5nxfKnkFCoZZfoo3EhTGfsT LYN1J5+1UOQMpriQlReQXQK6ij23CcURfjjII9XxQi0kY+gEYdSf7wdWJ8vGNJupJz8R IDYThCAYwUwQnBjQdkBJgPcs51svWzRj2J8A2SV8PcOS9iHPrTn532JuFD7yr63eq4+R FSbzv92ZZm1VfjNTbXuphpOYhH17X0ImZAKS6uFUTgeeHlrO7tPlEJ8qkfx/RXbQrKtn kvWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=mmlaDMLTqQCoVwWxbD+B5T02aWWKiBqosdz5bFfwjM4=; b=mhl/d/bdU0ye4pZjTXuRNnBcpJmE4FiUeCfQlpeTwZVYXm8kMb5DLs0h6yYBxj1+Ux czA73Lzif5q6V25ShNJNN4ngWtvGRges2NcQrjvREobSDbfVDRkGNo66GzxnQ49/kkHx R5ejOd1FbxQrcAVYRz0Lky2UOpYqZjcX8FuhQiDcCYf71cKctyPRvbOEgVfHzUGBri6x OhX8FqqqrCNn6RtKeJiBCXkzYuRJTOsYvWL6M2101NRnhbZ6PCgGL6Z/PUK/KG5zH3xj ++WiTWaetDQujS4xeREn+51MQ24IDQm7MfS+hhFXH524FrV+aqzc3ylrRuF/0rA+DG8V 9zUA== X-Gm-Message-State: AIkVDXLv3vLb/x6S+3JxnDUDimHwKsFFYaeXP1cnh5azMf21riiIrBBv/dP+wnOkyxYo9g== X-Received: by 10.99.253.85 with SMTP id m21mr5294227pgj.38.1484760496108; Wed, 18 Jan 2017 09:28:16 -0800 (PST) Received: from localhost.localdomain (c-73-223-93-234.hsd1.ca.comcast.net. [73.223.93.234]) by smtp.gmail.com with ESMTPSA id t21sm2255747pfa.1.2017.01.18.09.28.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jan 2017 09:28:15 -0800 (PST) From: Liam Breck To: Sebastian Reichel Cc: linux-pm@vger.kernel.org, Mark Greer , Tony Lindgren , Liam Breck Subject: [PATCH v4 1/7] power: bq24190_charger: Fix irq trigger to IRQF_TRIGGER_FALLING Date: Wed, 18 Jan 2017 09:26:48 -0800 Message-Id: <20170118172654.19416-2-liam@networkimprov.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170118172654.19416-1-liam@networkimprov.net> References: <20170118172654.19416-1-liam@networkimprov.net> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The interrupt signal is TRIGGER_FALLING. This is is specified in the data sheet PIN FUNCTIONS: "The INT pin sends active low, 256us pulse to host to report charger device status and fault." Also the direction can be seen in the data sheet Figure 37 "BQ24190 with D+/D- Detection and USB On-The-Go (OTG)" which shows a 10k pull-up resistor installed for the sample configurations. Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger") Signed-off-by: Liam Breck Acked-by: Mark Greer Acked-by: Tony Lindgren --- drivers/power/supply/bq24190_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c index 694c088..f5746b9 100644 --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c @@ -1394,7 +1394,7 @@ static int bq24190_probe(struct i2c_client *client, ret = devm_request_threaded_irq(dev, bdi->irq, NULL, bq24190_irq_handler_thread, - IRQF_TRIGGER_RISING | IRQF_ONESHOT, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "bq24190-charger", bdi); if (ret < 0) { dev_err(dev, "Can't set up irq handler\n");