From patchwork Wed Mar 1 23:44:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 9599231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2D10F604DC for ; Wed, 1 Mar 2017 23:45:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C4152842B for ; Wed, 1 Mar 2017 23:45:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B9DA28559; Wed, 1 Mar 2017 23:45:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC6D728428 for ; Wed, 1 Mar 2017 23:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753462AbdCAXpu (ORCPT ); Wed, 1 Mar 2017 18:45:50 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34545 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514AbdCAXpt (ORCPT ); Wed, 1 Mar 2017 18:45:49 -0500 Received: by mail-pg0-f68.google.com with SMTP id s67so7269820pgb.1; Wed, 01 Mar 2017 15:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=gHDLWDZT8keFgQ9I52XdfEZJ/r+3YAjLqL6yGUn59jk=; b=iJCZ2wTYYFCdRW36SzBhM2/ypZhYLelVQiv/y0Pk9qwUDJ5N8XOM8qBFfuQwLsZfMr MY6rwQtVHcoDjncl0UZ2y5m1OrMnbub4x1L60xjnggjV8AUSIagworkcyFjcncoUbwng 0WzVgaMThRmrNTouVx+uuOA3AdYLo4TjidgLR+3CvbvrB1htPLWZ0wNdEiFtPr78Or/r FStZk2dZ833lBJJGZlylVYPxRtqXn2iylEg7jAPtfDULCBerpaEaCiV7IqZLNQg/hAhj dnBLcmb2xUboww7Q/64qdNlskF25QghObbd8eZ+SbXQ4CxhHtFQQsY7zpK2pzeyIRhzi vFNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=gHDLWDZT8keFgQ9I52XdfEZJ/r+3YAjLqL6yGUn59jk=; b=JLiOwTgmrfUKv7Y/bBFNKJIBllMBhHI2npFrmMLwBR6DlyQnzoBrbStgIEYK6sN5Vf nCMbqYdqUivySQri9Eh+63FzRdXYHendXhWY5Vw33Mj8il+PDrXXWqvyLQtpC4qqH+FG 89bnRl0ECi4PK083HSNWGfYIgZduFs5BWrIJK2ZYHI7O3gdjY0S04m6zazufQJgViJEs lAFzsQ2EQbnUNWmMSIH908B2HfiFuayFgE/AaWKLwnWAVoY3qRu3I7orq2yX0piK7i8i Xa9h4ZhJVi/Uvjl7J63l4VWB5SSQ/uQtUIx9Q7KmCmz6qxMu4c4lfPL3e44221l2+PC9 Vy/A== X-Gm-Message-State: AMke39ksyTqNp1eDoDrhGZMQG4p20orYZD46dmfFn297IyBOP/fLMO8Kelvx3h7nxC90sQ== X-Received: by 10.98.11.9 with SMTP id t9mr11837885pfi.123.1488411896405; Wed, 01 Mar 2017 15:44:56 -0800 (PST) Received: from dtor-ws ([2620:0:1000:1311:f18a:a6c4:f29d:1ab0]) by smtp.gmail.com with ESMTPSA id m3sm12648212pfc.66.2017.03.01.15.44.55 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 01 Mar 2017 15:44:55 -0800 (PST) Date: Wed, 1 Mar 2017 15:44:53 -0800 From: Dmitry Torokhov To: Sebastian Reichel Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] power: supply: twl4030_charger: remove incorrect __exit markups Message-ID: <20170301234453.GA13831@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov --- drivers/power/supply/twl4030_charger.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c index bcd4dc304f27..990ff3d218bc 100644 --- a/drivers/power/supply/twl4030_charger.c +++ b/drivers/power/supply/twl4030_charger.c @@ -1117,7 +1117,7 @@ static int twl4030_bci_probe(struct platform_device *pdev) return ret; } -static int __exit twl4030_bci_remove(struct platform_device *pdev) +static int twl4030_bci_remove(struct platform_device *pdev) { struct twl4030_bci *bci = platform_get_drvdata(pdev); @@ -1148,11 +1148,11 @@ MODULE_DEVICE_TABLE(of, twl_bci_of_match); static struct platform_driver twl4030_bci_driver = { .probe = twl4030_bci_probe, + .remove = twl4030_bci_remove, .driver = { .name = "twl4030_bci", .of_match_table = of_match_ptr(twl_bci_of_match), }, - .remove = __exit_p(twl4030_bci_remove), }; module_platform_driver(twl4030_bci_driver);