From patchwork Thu Apr 6 03:10:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liam Breck X-Patchwork-Id: 9665983 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 378DC602B5 for ; Thu, 6 Apr 2017 03:11:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B2762823E for ; Thu, 6 Apr 2017 03:11:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F8BD28329; Thu, 6 Apr 2017 03:11:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A612F2823E for ; Thu, 6 Apr 2017 03:11:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752194AbdDFDL1 (ORCPT ); Wed, 5 Apr 2017 23:11:27 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36193 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbdDFDL0 (ORCPT ); Wed, 5 Apr 2017 23:11:26 -0400 Received: by mail-pg0-f66.google.com with SMTP id 81so5196896pgh.3 for ; Wed, 05 Apr 2017 20:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=tAhWt2QFRH3g0DchnzesQIwO73VCQxsX5h/abcl+f0Y=; b=rmPh5259bT7faSRfs4+MZCGwElScb9kfZyNEQMO748f/glhZKQwdiEPRL77jS7A4B4 QxM4ZirneoNyPTGTaznOyKI+Oac+623Me3Di1sI14vxON5tSjJpGRtQt0cxmSbgU1Y2e qPMfWafRuzY0OsNA3XC5hYjMiXmu6UyP1KJwliq0XyVuwdJ/D0mQaoMT9Gw13IktuKyQ klbjS3fg4Mq/knEb9kyI0uB079ctcK2IIVaPCAImdgOXZ6Akixd0p/Hhdhc7Rj5pkL2g Saziywvxb9MzSCa5GbkGte8p8xXm/7XDSp8b1q/u3PDCGAUw/rOSxLL7Rrcqa9ij6fT2 0vXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=tAhWt2QFRH3g0DchnzesQIwO73VCQxsX5h/abcl+f0Y=; b=nCwRWWOH/n4O9+h16jMvZLUD5VGNBM/tx6DwXg+opoZ+hauR1w/pSUM7oW3vnH58aQ EpPLnLGynHeDUQGUt0s+Ycg6RwmgdsIoGXpPnZwgitStku+r87IuSClY5DBx/ufzrKIj JL4122tzbshkJwOInmwDIc6+IQtClz8vNGuq1kg13s2z0kSNr/mEpZKQsB582GQulExc 9qTSNFVzGmm++LPXh9lYMKZvl3GbwoENU7PwafQxD8qVYvCSjp1K5S9pYwXLicKNrH0p LN9NWFVyijvhcminhJ2Dc6qitpnHd+Ux2wCkuFYXC337cJ3tB7exiyZTLZREFT7X4zbe peSQ== X-Gm-Message-State: AFeK/H3CXUcpb5QYxTWlaOTtl8KmB1MQhJK/+k2CsfUXrz7tX0OSchFNzgOmXNUBXzSzHg== X-Received: by 10.84.133.133 with SMTP id f5mr40555683plf.64.1491448285646; Wed, 05 Apr 2017 20:11:25 -0700 (PDT) Received: from localhost.localdomain (c-73-223-93-234.hsd1.ca.comcast.net. [73.223.93.234]) by smtp.gmail.com with ESMTPSA id d130sm312780pga.17.2017.04.05.20.11.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 20:11:25 -0700 (PDT) From: Liam Breck To: Sebastian Reichel , linux-pm@vger.kernel.org Cc: Tony Lindgren , Hans de Goede , Liam Breck Subject: [PATCH v4 1/4] power: bq24190_charger: Limit over/under voltage fault logging Date: Wed, 5 Apr 2017 20:10:45 -0700 Message-Id: <20170406031048.12401-2-liam@networkimprov.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170406031048.12401-1-liam@networkimprov.net> References: <20170406031048.12401-1-liam@networkimprov.net> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Liam Breck If the charger is unplugged before the battery is full we may see an over/under voltage fault. Ignore this rather then emitting a message or uevent. This prevents messages like these on charger unplug/replug: bq24190-charger 15-006b: Fault: boost 0, charge 1, battery 0, ntc 0 bq24190-charger 15-006b: Fault: boost 0, charge 0, battery 0, ntc 0 Cc: Tony Lindgren Cc: Hans de Goede Signed-off-by: Liam Breck Reviewed-by: Hans de Goede --- drivers/power/supply/bq24190_charger.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c index a699ad3..64a48b9 100644 --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c @@ -1222,8 +1222,13 @@ static void bq24190_check_status(struct bq24190_dev_info *bdi) } } while (f_reg && ++i < 2); + /* ignore over/under voltage fault after disconnect */ + if (f_reg == (1 << BQ24190_REG_F_CHRG_FAULT_SHIFT) && + !(ss_reg & BQ24190_REG_SS_PG_STAT_MASK)) + f_reg = 0; + if (f_reg != bdi->f_reg) { - dev_info(bdi->dev, + dev_warn(bdi->dev, "Fault: boost %d, charge %d, battery %d, ntc %d\n", !!(f_reg & BQ24190_REG_F_BOOST_FAULT_MASK), !!(f_reg & BQ24190_REG_F_CHRG_FAULT_MASK),