From patchwork Tue Apr 11 11:59:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liam Breck X-Patchwork-Id: 9675009 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C8AA6600CB for ; Tue, 11 Apr 2017 12:00:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C38BB2711E for ; Tue, 11 Apr 2017 12:00:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B861428563; Tue, 11 Apr 2017 12:00:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C71742711E for ; Tue, 11 Apr 2017 12:00:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbdDKMAC (ORCPT ); Tue, 11 Apr 2017 08:00:02 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36717 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbdDKMAB (ORCPT ); Tue, 11 Apr 2017 08:00:01 -0400 Received: by mail-pg0-f66.google.com with SMTP id 81so29607551pgh.3 for ; Tue, 11 Apr 2017 05:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=sRdnD1dxXPFCkDJiTFbdkoeqtBPdeU5qT1ISYdeDYw4=; b=k8fPrkSH6aAqvRet23xPWV9yDar1w9Q43DvDrTSsCc3AjW1L1bvPAvsIi6Vy7/rmDf k1Q62XZDIOgV9DVbOtVF1neLpWpx6GOJ9SZUTMyApmKt6wq475O13UxRMv5aK0VrW4YP 27zIuWGYEHhxaaqxmNZAZ6lsjOcUa40oWm1Jx2732WCgAwnb8I6gbgDQRmOmrpo10HFq XTiSFtxyIqaHGILjljMV+RldYZDQmlDKXE/bzZlOidQZSp3tNMoFMsWxyOaS1gLrBwbY UxLMuU0lHuv6aQy4Bu3LxrN0Y4QEhSdXCU1zqX2B4P0Su2X6N6rpL5QOe77hBlIx37M1 CiJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=sRdnD1dxXPFCkDJiTFbdkoeqtBPdeU5qT1ISYdeDYw4=; b=rQCfSCXePUFl4MHUqxw49v0om1f3E59Cywkj+ib76zwxt9FZL+gCq4Sf964wpX/1Qv wGPpcjrmmtekjCCl4Afx4UhxJPmN3ncjqodRDI3bMc8S0/Gugbc3LUOAjIDuHbn7WjuT crsS3PJk/aPOc8d119mtx7edM9jifXIXWmPb/bYSYSKV1m1JeMiMbNTH90MuvHSOZYwx 55GQ4q7qxzOWtg3AmSiq1HDyOsEwGmDdE0pctBFaVnBT6UCa4cbXt6G/3LYBkiUmzWYP 49Sa+XALkqipfcmunboE8PRw7UssbIMCeF43ESvUboMwlA1r8tBhT5VfXLr+mgEyGHu/ 2t1w== X-Gm-Message-State: AFeK/H0a3NhOmBJM9EPINghGxQB48q2FY9WWSsJwvcYXGKL2wvDeOcLRkaGO8hXGKFAgZQ== X-Received: by 10.84.175.67 with SMTP id s61mr74213194plb.126.1491912000808; Tue, 11 Apr 2017 05:00:00 -0700 (PDT) Received: from localhost.localdomain (c-73-223-93-234.hsd1.ca.comcast.net. [73.223.93.234]) by smtp.gmail.com with ESMTPSA id d3sm30444736pgc.37.2017.04.11.04.59.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Apr 2017 05:00:00 -0700 (PDT) From: Liam Breck To: Sebastian Reichel , linux-pm@vger.kernel.org Cc: Tony Lindgren , Hans de Goede , Liam Breck Subject: [PATCH v5 1/4] power: bq24190_charger: Limit over/under voltage fault logging Date: Tue, 11 Apr 2017 04:59:54 -0700 Message-Id: <20170411115957.14253-2-liam@networkimprov.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170411115957.14253-1-liam@networkimprov.net> References: <20170411115957.14253-1-liam@networkimprov.net> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Liam Breck If the charger is unplugged before the battery is full we may see an over/under voltage fault. Ignore this rather then emitting a message or uevent. This fixes messages like these getting logged on charger unplug + replug: bq24190-charger 15-006b: Fault: boost 0, charge 1, battery 0, ntc 0 bq24190-charger 15-006b: Fault: boost 0, charge 0, battery 0, ntc 0 Cc: Tony Lindgren Cc: Hans de Goede Signed-off-by: Liam Breck Acked-by: Tony Lindgren Reviewed-by: Hans de Goede --- drivers/power/supply/bq24190_charger.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c index a699ad3..64a48b9 100644 --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c @@ -1222,8 +1222,13 @@ static void bq24190_check_status(struct bq24190_dev_info *bdi) } } while (f_reg && ++i < 2); + /* ignore over/under voltage fault after disconnect */ + if (f_reg == (1 << BQ24190_REG_F_CHRG_FAULT_SHIFT) && + !(ss_reg & BQ24190_REG_SS_PG_STAT_MASK)) + f_reg = 0; + if (f_reg != bdi->f_reg) { - dev_info(bdi->dev, + dev_warn(bdi->dev, "Fault: boost %d, charge %d, battery %d, ntc %d\n", !!(f_reg & BQ24190_REG_F_BOOST_FAULT_MASK), !!(f_reg & BQ24190_REG_F_CHRG_FAULT_MASK),