From patchwork Tue Apr 11 11:59:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liam Breck X-Patchwork-Id: 9675015 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 317F360382 for ; Tue, 11 Apr 2017 12:00:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2ED292711E for ; Tue, 11 Apr 2017 12:00:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 23B8B2855A; Tue, 11 Apr 2017 12:00:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C14322711E for ; Tue, 11 Apr 2017 12:00:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbdDKMAF (ORCPT ); Tue, 11 Apr 2017 08:00:05 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:35061 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754551AbdDKMAE (ORCPT ); Tue, 11 Apr 2017 08:00:04 -0400 Received: by mail-pg0-f68.google.com with SMTP id g2so29557929pge.2 for ; Tue, 11 Apr 2017 05:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=B0eYfMvksauiBRipcAZFNHjpp90uxC1u0YnKoKN6wa8=; b=POJaR1kHQMex/tvSrjNK2uK2+iC53t4uxbE9lQm3Tf5Do25tfoFcfWpwPwcC0xHHC4 LbnybwPQUesHRAx2pSRL16U7qA0bDiwSTDIignLLsUSNodbVmp7ZW086crb2AY5JUa9m FSiZjd8zCoydL26nl94Jok0lA9+yzGFIfmAU7+pPHx+6SVXLovfy3g/VhDc+Mv46J+mQ yMPNNYZjD6RYV9CDy5FFlWdVSB51JJpZJXrBIJvO69YwSG7tMz9P1c7Cq3ki/l3NY+zr YGmgqtYewf8znilgJ9JKCdTe7awgvtI61Ggqq9O+o5iE2HttEwp83dfW8sof8U9AQ6VR Oanw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=B0eYfMvksauiBRipcAZFNHjpp90uxC1u0YnKoKN6wa8=; b=bwKux9OAZ6azGtARdvsPaSomiJnb/lfKMTF6ot8pKJFPE6/1CBsyLE39QMFa8suHPz wpvhuwKGQn4TQPSZ8Pf+BUuz3u+ne5j4JrtEEuAdz1CaWWXkAuS2QVu1sobQqEKQ2weU Mf9cRuRuKdr1cTXvBgRuzblKCXjdzg47JSK7kVmhdarSaovflq9300sbaQon3/iYZpLA Uo0UaI6eDuiumqeVZgRkLVetpJrQmcwMK/toLP8gAmfBDy25nHFzJsnbEPZheoULVqsv gjBq2QwZ2cAij6u4H42e2qKYqW+MWicM+H7UNDMDmtwg3j6nBUh14JrnEiEGtE17peAd pTbA== X-Gm-Message-State: AN3rC/7qFo2V4ZDBnOe6Lvu6EY6ecQxgJG1pxHGJOc+cIdXP4KF9rC28FBnUhdlAKx0dnQ== X-Received: by 10.84.217.12 with SMTP id o12mr105330pli.87.1491912004234; Tue, 11 Apr 2017 05:00:04 -0700 (PDT) Received: from localhost.localdomain (c-73-223-93-234.hsd1.ca.comcast.net. [73.223.93.234]) by smtp.gmail.com with ESMTPSA id d3sm30444736pgc.37.2017.04.11.05.00.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Apr 2017 05:00:03 -0700 (PDT) From: Liam Breck To: Sebastian Reichel , linux-pm@vger.kernel.org Cc: Tony Lindgren , Hans de Goede , Liam Breck Subject: [PATCH v5 4/4] power: bq24190_charger: Longer delay while polling reset flag Date: Tue, 11 Apr 2017 04:59:57 -0700 Message-Id: <20170411115957.14253-5-liam@networkimprov.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170411115957.14253-1-liam@networkimprov.net> References: <20170411115957.14253-1-liam@networkimprov.net> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Liam Breck On chip reset, polling loop used udelay(10) which is too short to be useful. Instead, use usleep_range(100, 200). Cc: Tony Lindgren Cc: Hans de Goede Signed-off-by: Liam Breck Acked-by: Tony Lindgren --- drivers/power/supply/bq24190_charger.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c index a904abb..f581042 100644 --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c @@ -550,16 +550,13 @@ static int bq24190_register_reset(struct bq24190_dev_info *bdi) if (ret < 0) return ret; + if (v == 0) + return 0; - if (!v) - break; - udelay(10); + usleep_range(100, 200); } while (--limit); - if (!limit) - return -EIO; - - return 0; + return -EIO; } /* Charger power supply property routines */