From patchwork Sat May 20 17:05:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 9738697 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A31BC6020A for ; Sat, 20 May 2017 17:05:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 85E1828685 for ; Sat, 20 May 2017 17:05:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 76C6B28689; Sat, 20 May 2017 17:05:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 02A2528685 for ; Sat, 20 May 2017 17:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754347AbdETRFj (ORCPT ); Sat, 20 May 2017 13:05:39 -0400 Received: from muru.com ([72.249.23.125]:48566 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813AbdETRFi (ORCPT ); Sat, 20 May 2017 13:05:38 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6F98380F9; Sat, 20 May 2017 17:08:53 +0000 (UTC) Date: Sat, 20 May 2017 10:05:33 -0700 From: Tony Lindgren To: Sebastian Reichel Cc: linux-pm@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Marcel Partap , Michael Scott , Rob Herring Subject: Re: [PATCH] power: supply: cpcap-battery: Add a battery driver Message-ID: <20170520170533.GN10472@atomide.com> References: <20170519055146.2038-1-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170519055146.2038-1-tony@atomide.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP * Tony Lindgren [170518 22:55]: > Note that I left out the battery interrupt handling for now as I need > to spend more time on it for the battery empty interrupts. The driver > works just fine without the interrupts too. ... > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt > @@ -0,0 +1,27 @@ > +Motorola CPCAP PMIC battery driver binding > + > +Required properties: > +- compatible: Shall be "motorola,cpcap-battery" > +- interrupts: Interrupt specifier for each name in interrupt-names > +- interrupt-names: Should contain the following entries: > + "lowbph", "lowbpl", "chrgcurr1", "battdetb" > +- io-channels: IIO ADC channel specifier for each name in io-channel-names > +- io-channel-names: Should contain the following entries: > + "battdetb", "battp" > + > +Example: > + > +cpcap_battery: battery { > + compatible = "motorola,cpcap-battery"; > + interrupts-extended = < > + &cpcap 5 0 &cpcap 3 0 > + &cpcap 20 0 &cpcap 54 0 > + >; > + interrupt-names = > + "lowbph", "lowbpl", > + "chrgcurr1", "battdetb"; > + io-channels = <&cpcap_adc 0 &cpcap_adc 1 > + &cpcap_adc 5 &cpcap_adc 6>; > + io-channel-names = "battdetb", "battp", > + "chg_isense", "batti"; > +}; I guess we should leave out the interrupts in the binding for now too. Or at least move them to optional properties. Anyways, below is the related dts patch I've been using. Regards, Tony 8< ------------------------- From tony Mon Sep 17 00:00:00 2001 From: Tony Lindgren Date: Fri, 19 May 2017 14:23:25 -0700 Subject: [PATCH] ARM: dts: omap4-droid4: Configure CPCAP battery driver Configure CPCAP battery driver. Signed-off-by: Tony Lindgren --- arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi --- a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi +++ b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi @@ -26,6 +26,21 @@ #io-channel-cells = <1>; }; + cpcap_battery: battery { + compatible = "motorola,cpcap-battery"; + interrupts-extended = < + &cpcap 5 0 &cpcap 3 0 + &cpcap 20 0 &cpcap 54 0 + >; + interrupt-names = + "lowbph", "lowbpl", + "chrgcurr1", "battdetb"; + io-channels = <&cpcap_adc 0 &cpcap_adc 1 + &cpcap_adc 5 &cpcap_adc 6>; + io-channel-names = "battdetb", "battp", + "chg_isense", "batti"; + }; + cpcap_charger: charger { compatible = "motorola,mapphone-cpcap-charger"; interrupts-extended = <