From patchwork Fri Jun 9 16:08:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 9778903 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 576D960350 for ; Fri, 9 Jun 2017 16:12:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 462292863C for ; Fri, 9 Jun 2017 16:12:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 396D92864F; Fri, 9 Jun 2017 16:12:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E3CFC2863C for ; Fri, 9 Jun 2017 16:11:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751816AbdFIQJP (ORCPT ); Fri, 9 Jun 2017 12:09:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:57328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbdFIQJN (ORCPT ); Fri, 9 Jun 2017 12:09:13 -0400 Received: from kozik-lap.dzcmts001-cpe-001.datazug.ch (pub082136089155.dh-hfc.datazug.ch [82.136.89.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35CF8239F5; Fri, 9 Jun 2017 16:09:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35CF8239F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org From: Krzysztof Kozlowski To: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Greg Kroah-Hartman , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/8] PM / domains: Protect reading loop over list of domains Date: Fri, 9 Jun 2017 18:08:47 +0200 Message-Id: <20170609160853.31789-3-krzk@kernel.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170609160853.31789-1-krzk@kernel.org> References: <20170609160853.31789-1-krzk@kernel.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The pm_genpd_present() iterates over list of domains so grabbing a gpd_list_lock mutex is necessary before calling it. Otherwise we could end up in iterating over and modifying the list at the same time. Signed-off-by: Krzysztof Kozlowski --- drivers/base/power/domain.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 2e8d0f423507..2a6935dc0164 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -1099,8 +1099,13 @@ static void genpd_syscore_switch(struct device *dev, bool suspend) struct generic_pm_domain *genpd; genpd = dev_to_genpd(dev); - if (!pm_genpd_present(genpd)) + + mutex_lock(&gpd_list_lock); + if (!pm_genpd_present(genpd)) { + mutex_unlock(&gpd_list_lock); return; + } + mutex_unlock(&gpd_list_lock); if (suspend) { genpd->suspended_count++;