| Message ID | 20170719195012.30187-1-salyzyn@android.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
> +#if defined(CONFIG_RTC_SHOW_TIME_RTC) > + { > + struct rtc_time tm; > + > + rtc_time64_to_tm(ts.tv_sec, &tm); > + pr_info("%s %d-%02d-%02d %02d:%02d:%02d.%09lu UTC\n", > + prefix_msg ? prefix_msg : "Time:", > + tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday, > + tm.tm_hour, tm.tm_min, tm.tm_sec, ts.tv_nsec); > + } > +#else This was NAKed before. Are you even listening, or are you trying to flood us with enough mail so that someone applies your patches by mistake? Pavel
On 07/20/2017 01:26 AM, Pavel Machek wrote: >> +#if defined(CONFIG_RTC_SHOW_TIME_RTC) >> + { >> + struct rtc_time tm; >> + >> + rtc_time64_to_tm(ts.tv_sec, &tm); >> + pr_info("%s %d-%02d-%02d %02d:%02d:%02d.%09lu UTC\n", >> + prefix_msg ? prefix_msg : "Time:", >> + tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday, >> + tm.tm_hour, tm.tm_min, tm.tm_sec, ts.tv_nsec); >> + } >> +#else > > This was NAKed before. Are you even listening, or are you trying to > flood us with enough mail so that someone applies your patches by > mistake? > Pavel It was NAKed in the group, I put it aside in its own patch to keep from throwing out the baby with the bathwater. Was hoping that a private CONFIG_RTC_SHOW_TIME_RTC would be acceptable. I guess not, topic is dead. A refresh is being tested that addresses many of the other concerns. -- Mark
diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig index 2dc891056635..3c2920b8825c 100644 --- a/kernel/time/Kconfig +++ b/kernel/time/Kconfig @@ -221,4 +221,21 @@ choice continues, and the timestamps help re-orient post-analysis. Print boottime <s>.<ns> timestamp in rtc_show_time + config RTC_SHOW_TIME_RTC + bool "realtime in wall clock format" + select RTC_SHOW_TIME + select RTC_LIB + help + Activate optional rtc_show_time(const char *msg) wall clock + time instrumentation. + + The primary use of the instrumentation is to aid field + analysis of Battery and Power usage. The instrumentation + may also help triage and synchronize kernel logs and user + space activity logs at key displacements. For instance + CLOCK_MONOTONIC stops while suspended, while CLOCK_REALTIME + continues, and the timestamps help re-orient post-analysis. + + Print realtime YYYY-MM-DD hh:mm:ss.<ns> timestamp in + rtc_show_time. endchoice diff --git a/kernel/time/rtc_show_time.c b/kernel/time/rtc_show_time.c index 6c7b8ae6be0c..d861a30aef77 100644 --- a/kernel/time/rtc_show_time.c +++ b/kernel/time/rtc_show_time.c @@ -24,9 +24,21 @@ void rtc_show_time(const char *prefix_msg) struct timespec64 ts; getnstimeofday64(&ts); +#if defined(CONFIG_RTC_SHOW_TIME_RTC) + { + struct rtc_time tm; + + rtc_time64_to_tm(ts.tv_sec, &tm); + pr_info("%s %d-%02d-%02d %02d:%02d:%02d.%09lu UTC\n", + prefix_msg ? prefix_msg : "Time:", + tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday, + tm.tm_hour, tm.tm_min, tm.tm_sec, ts.tv_nsec); + } +#else pr_info("%s %lu.%09lu UTC\n", prefix_msg ? prefix_msg : "Time:", ts.tv_sec, ts.tv_nsec); #endif +#endif } EXPORT_SYMBOL(rtc_show_time);
Add an option to report REALTIME in RTC time format for rtc_show_time() function. Feature activated by CONFIG_RTC_SHOW_TIME_RTC. Signed-off-by: Mark Salyzyn <salyzyn@android.com> --- kernel/time/Kconfig | 17 +++++++++++++++++ kernel/time/rtc_show_time.c | 12 ++++++++++++ 2 files changed, 29 insertions(+)