From patchwork Sun Sep 3 13:16:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 9936325 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 311E96038C for ; Sun, 3 Sep 2017 13:16:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 21EF3285EF for ; Sun, 3 Sep 2017 13:16:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 149B82867D; Sun, 3 Sep 2017 13:16:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 917C1285EF for ; Sun, 3 Sep 2017 13:16:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752915AbdICNQZ (ORCPT ); Sun, 3 Sep 2017 09:16:25 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:41110 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbdICNQY (ORCPT ); Sun, 3 Sep 2017 09:16:24 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1doUlA-00064U-Az; Sun, 03 Sep 2017 13:16:20 +0000 From: Colin King To: Markus Mayer , bcm-kernel-feedback-list@broadcom.com, Zhang Rui , Eduardo Valentin , Brian Norris , Gregory Fong , Florian Fainelli , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks Date: Sun, 3 Sep 2017 14:16:19 +0100 Message-Id: <20170903131619.6857-1-colin.king@canonical.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Colin Ian King The comparisons for integer low on low > INT_MAX and also integer high > INT_MAX are never going to be true since an int type cannot be greater than INT_MAX. Remove these redundant checks. Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect result (CONSTANT_EXPRESSION_RESULT)") Signed-off-by: Colin Ian King --- drivers/thermal/broadcom/brcmstb_thermal.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c index 87b8e7a86ee3..bcb3945feea6 100644 --- a/drivers/thermal/broadcom/brcmstb_thermal.c +++ b/drivers/thermal/broadcom/brcmstb_thermal.c @@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high) dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high); if (low) { - if (low > INT_MAX) - low = INT_MAX; avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low); avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1); } else { @@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high) } if (high < ULONG_MAX) { - if (high > INT_MAX) - high = INT_MAX; avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high); avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1); } else {