From patchwork Mon Dec 18 23:30:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 10122067 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 616ED60327 for ; Mon, 18 Dec 2017 23:31:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 50E4C28F92 for ; Mon, 18 Dec 2017 23:31:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 43F4B28EF3; Mon, 18 Dec 2017 23:31:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 832F028F92 for ; Mon, 18 Dec 2017 23:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936162AbdLRXbO (ORCPT ); Mon, 18 Dec 2017 18:31:14 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:44198 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936156AbdLRXbK (ORCPT ); Mon, 18 Dec 2017 18:31:10 -0500 Received: by mail-io0-f193.google.com with SMTP id w127so11637295iow.11 for ; Mon, 18 Dec 2017 15:31:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=7eGfNqwwm6ZXqNKKyXpzaH6JUpsoJ5BlUW/JRruQCL4=; b=ZbMXIiPuu9i3viVcuthCEyju7Qa0kbLdkqU+tUp4e+Y2o15LgGFhy8f5lpYqlv/emR +YA/LUPmghC/iwvL8diNDwac34MwuJJegBIVh+GT1J4gerwmMDcmLFemgqeqLTO20tSY LupGombzLCLll2lENRMMR9aqLOhH7rzk4/ctA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7eGfNqwwm6ZXqNKKyXpzaH6JUpsoJ5BlUW/JRruQCL4=; b=R3srgXVsuhE7GXVNlXeUbv/XYKGy16iZgi2OZX3ZcIxvVI6I8qU5c0IrOfyLH+03oH y9LAXi3EiJhjpoOmt/LDM158SNuaNPDO/wzDazLIKj1YfB236fI9ttGcI8Uq0V6Ojdzc aZDr9nq8FNJdP+35jXCONJpXxDLjlhKG/8yf6daum/k5zGrzO70AGwSQOdJ7Vo3AmOnf pd4WigNzKi+4eEGRRGRJTq8DFlucE89A6NQpGCglBvq+Kq/Ted6lVDqGomgZ2WdtGHNn rBANLPJJ1MSQozN4zvVL9gZiVqRJZygPBFxs1JzWBXe1JnDrBEodtGgYtggFzjHN3DUD T0JA== X-Gm-Message-State: AKGB3mKZXnj5KB58mgXExM92uPRrlZZQ0AW7XHl7yQ7Y5N/3yhMdk7hx njY3kRCLi3jue/jm9azKvlMuWg== X-Google-Smtp-Source: ACJfBovF7Us/jTbsBlkkbcGwdTLemLS6W2Y98pnM42ndPUlZq+ZHIpSt9cCOMOnVdM9EAEExeu5V4w== X-Received: by 10.107.24.198 with SMTP id 189mr1715458ioy.213.1513639869933; Mon, 18 Dec 2017 15:31:09 -0800 (PST) Received: from ban.mtv.corp.google.com ([172.22.113.17]) by smtp.gmail.com with ESMTPSA id w68sm7593530iow.18.2017.12.18.15.31.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Dec 2017 15:31:09 -0800 (PST) From: Brian Norris To: "Rafael J. Wysocki" , Len Brown , Pavel Machek Cc: , linux-pm@vger.kernel.org, Tony Lindgren , Brian Norris Subject: [PATCH TRIVIAL] PM / wakeup: only recommend "call"ing device_init_wakeup() once Date: Mon, 18 Dec 2017 15:30:48 -0800 Message-Id: <20171218233048.156954-1-briannorris@chromium.org> X-Mailer: git-send-email 2.15.1.504.g5279b80103-goog Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I'll admit admit it: I've written bad driver code that tries to configure a device's wake IRQ without having called device_init_wakeup() first. But do you really have to ask ask me twice? Signed-off-by: Brian Norris --- drivers/base/power/wakeup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c index 38559f04db2c..cb72965b3281 100644 --- a/drivers/base/power/wakeup.c +++ b/drivers/base/power/wakeup.c @@ -298,7 +298,7 @@ int device_wakeup_attach_irq(struct device *dev, ws = dev->power.wakeup; if (!ws) { - dev_err(dev, "forgot to call call device_init_wakeup?\n"); + dev_err(dev, "forgot to call device_init_wakeup?\n"); return -EINVAL; }