| Message ID | 20180505011328.32078-4-shuah@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 04-05-18, 19:13, Shuah Khan (Samsung OSG) wrote: > When cpufreq test is skipped because of unmet dependencies and/or > unsupported configuration, it exits with error which is treated as > a fail by the Kselftest framework. This leads to false negative > result even when the test could not be run. > > Change it to return kselftest skip code when a test gets skipped to > clearly report that the test could not be run. > > Kselftest framework SKIP code is 4 and the framework prints appropriate > messages to indicate that the test is skipped. > > Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> > --- > tools/testing/selftests/cpufreq/main.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh > index d83922de9d89..31f8c9a76c5f 100755 > --- a/tools/testing/selftests/cpufreq/main.sh > +++ b/tools/testing/selftests/cpufreq/main.sh > @@ -13,6 +13,9 @@ SYSFS= > CPUROOT= > CPUFREQROOT= > > +# Kselftest framework requirement - SKIP code is 4. > +ksft_skip=4 > + > helpme() > { > printf "Usage: $0 [-h] [-todg args] > @@ -38,7 +41,7 @@ prerequisite() > > if [ $UID != 0 ]; then > echo $msg must be run as root >&2 > - exit 2 > + exit $ksft_skip > fi > > taskset -p 01 $$ Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh index d83922de9d89..31f8c9a76c5f 100755 --- a/tools/testing/selftests/cpufreq/main.sh +++ b/tools/testing/selftests/cpufreq/main.sh @@ -13,6 +13,9 @@ SYSFS= CPUROOT= CPUFREQROOT= +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + helpme() { printf "Usage: $0 [-h] [-todg args] @@ -38,7 +41,7 @@ prerequisite() if [ $UID != 0 ]; then echo $msg must be run as root >&2 - exit 2 + exit $ksft_skip fi taskset -p 01 $$
When cpufreq test is skipped because of unmet dependencies and/or unsupported configuration, it exits with error which is treated as a fail by the Kselftest framework. This leads to false negative result even when the test could not be run. Change it to return kselftest skip code when a test gets skipped to clearly report that the test could not be run. Kselftest framework SKIP code is 4 and the framework prints appropriate messages to indicate that the test is skipped. Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> --- tools/testing/selftests/cpufreq/main.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)