| Message ID | 20180608223655.33565-2-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi, On Fri, Jun 08, 2018 at 03:36:55PM -0700, Brian Norris wrote: > This compatible property was documented before the driver was renamed to > "SBS" (see commit e57f1b68c406 ("devicetree-bindings: Propagate > bq20z75->sbs rename to dt bindings")). The driver has continued to > support this property as an alternative to "sbs,sbs-battery", and > because we've noticed there are some lingering TI specifics (in the > manufacturer-specific portion of the SBS spec), we'd like to start using > this property again to differentiate. > > Signed-off-by: Brian Norris <briannorris@chromium.org> > Acked-by: Rhyland Klein <rklein@nvidia.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- Please use "sbs,sbs-battery" as fallback, just like sbs-manager and sbs-charger, see for example: Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txt -- Sebastian > v2: add Rhyland's Acked-by > v3: no change > v4: add Rob's Reviewed-by > --- > .../devicetree/bindings/power/supply/sbs_sbs-battery.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt > index c40e8926facf..a7a9c3366f82 100644 > --- a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt > +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt > @@ -2,7 +2,7 @@ SBS sbs-battery > ~~~~~~~~~~ > > Required properties : > - - compatible : "sbs,sbs-battery" > + - compatible : "sbs,sbs-battery" or "ti,bq20z75" > > Optional properties : > - sbs,i2c-retry-count : The number of times to retry i2c transactions on i2c > -- > 2.18.0.rc1.242.g61856ae69a-goog >
diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt index c40e8926facf..a7a9c3366f82 100644 --- a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt @@ -2,7 +2,7 @@ SBS sbs-battery ~~~~~~~~~~ Required properties : - - compatible : "sbs,sbs-battery" + - compatible : "sbs,sbs-battery" or "ti,bq20z75" Optional properties : - sbs,i2c-retry-count : The number of times to retry i2c transactions on i2c
This compatible property was documented before the driver was renamed to "SBS" (see commit e57f1b68c406 ("devicetree-bindings: Propagate bq20z75->sbs rename to dt bindings")). The driver has continued to support this property as an alternative to "sbs,sbs-battery", and because we've noticed there are some lingering TI specifics (in the manufacturer-specific portion of the SBS spec), we'd like to start using this property again to differentiate. Signed-off-by: Brian Norris <briannorris@chromium.org> Acked-by: Rhyland Klein <rklein@nvidia.com> Reviewed-by: Rob Herring <robh@kernel.org> --- v2: add Rhyland's Acked-by v3: no change v4: add Rob's Reviewed-by --- .../devicetree/bindings/power/supply/sbs_sbs-battery.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)