From patchwork Tue Jun 12 20:20:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 10461169 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CF1D8601A0 for ; Tue, 12 Jun 2018 20:21:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B9E8828BB7 for ; Tue, 12 Jun 2018 20:21:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ADCD028BD5; Tue, 12 Jun 2018 20:21:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5FACB28BB7 for ; Tue, 12 Jun 2018 20:21:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933994AbeFLUVE (ORCPT ); Tue, 12 Jun 2018 16:21:04 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:42533 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933788AbeFLUUv (ORCPT ); Tue, 12 Jun 2018 16:20:51 -0400 Received: by mail-pf0-f195.google.com with SMTP id w7-v6so109980pfn.9 for ; Tue, 12 Jun 2018 13:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=w7WUnYdQJVMcSzZoxupiQCcgfxRPRjU/e1SHOb0pfpk=; b=MnUM7f7EoQu7nls/SwzWNojr0hK90sfV5FqWFLeaBpOzjrrfMwkFuWr5bn+EBJjiJh GUb4ysqOyGR477L2rciE13JApi20Twef9T5YoHUKrCy8s6ftam5pjCInn8uY8gYFf+/9 7R+HCoprSWAyhMh59pN4eg0L5oT3uHv8cUAys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=w7WUnYdQJVMcSzZoxupiQCcgfxRPRjU/e1SHOb0pfpk=; b=sMUozbAz/BtT7AOk8TLw8XO/6MmSdoN9O6R/S8H5hGBY1D+xLcPx7rVOLc6k7uRYbi 8iX/NxNAcRdesL5sx1PtgctXmjN7LJdAvTCPU1rKCT7jG/sH5GaYjBB8yFMIAaay9f3N NI+H76kDJa0BCLHQiKm4TsV/c4kovcAcSATshkQNy4LK0TPBCVVyu0C8VmAX4c3wUv2i eVbhYksoYqWmXQRKZ/R5jE3DgNz9ikuGuKE7QmYohiTyko4SBMZ4+6ovY4dgQ7t12Q8D fY/h4tYaiP69svifKasLEDTYHa3YANjmn6Nwn9XMi7UIldSd0gT/UWLPBB/WR6pl/XE/ QroA== X-Gm-Message-State: APt69E3g807MHzDOdwaTkiaQrpVrMImtYRu/Gx/ktvY2JCr1INZVskCW NuD25FWdtvZF1T8KKtTvKTZQ3LMBW/Y= X-Google-Smtp-Source: ADUXVKK858UGeUyVsv8eccUUa2GK+EnGBO7b8kRsLBzjFCJ2jtlmehgtrQMjqX24DWE9i8UIOQSI6A== X-Received: by 2002:aa7:818b:: with SMTP id g11-v6mr1928413pfi.50.1528834851235; Tue, 12 Jun 2018 13:20:51 -0700 (PDT) Received: from ban.mtv.corp.google.com ([2620:0:1000:1501:bc2f:3082:9938:5d41]) by smtp.gmail.com with ESMTPSA id z28-v6sm1136732pfl.169.2018.06.12.13.20.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jun 2018 13:20:50 -0700 (PDT) From: Brian Norris To: Sebastian Reichel Cc: , Rob Herring , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Rhyland Klein , Alexandru Stan , Guenter Roeck , Doug Anderson , Phil Reid , Brian Norris Subject: [PATCH 2/2] dt-bindings: power: sbs-battery: re-document "ti, bq20z75" Date: Tue, 12 Jun 2018 13:20:42 -0700 Message-Id: <20180612202042.107603-2-briannorris@chromium.org> X-Mailer: git-send-email 2.18.0.rc1.242.g61856ae69a-goog In-Reply-To: <20180612202042.107603-1-briannorris@chromium.org> References: <20180612202042.107603-1-briannorris@chromium.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This compatible property was documented before the driver was renamed to "SBS" (see commit e57f1b68c406 ("devicetree-bindings: Propagate bq20z75->sbs rename to dt bindings")). The driver has continued to support this property as an alternative to "sbs,sbs-battery", and because we've noticed there are some lingering TI specifics (in the manufacturer-specific portion of the SBS spec), we'd like to start using this property again to differentiate. In typical DT fashion, the , specifics should be used ahead of the generic "sbs,sbs-battery" string, so we can handle vendor specifics -- so document this. Language borrowed mostly from Documentation/devicetree/bindings/power/supply/sbs_sbs-charger.txt Also fixup the example to use this property (it's already implying that it's "bq20z75@b"); fixup the node name to be generic ("battery", not ""); and fixup some whitespace. Signed-off-by: Brian Norris Acked-by: Rhyland Klein Reviewed-by: Rob Herring --- v2: add Rhyland's Acked-by v3: no change v4: add Rob's Reviewed-by v5: * note "sbs,sbs-battery" as a fallback for vendor,part-number * improve the Example * I still kept the {Acked,Reviewed}-by, since the substance of the change is essentially the same. Apologies if that is not proper. --- .../bindings/power/supply/sbs_sbs-battery.txt | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt index c40e8926facf..4e78e51018eb 100644 --- a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt @@ -2,7 +2,11 @@ SBS sbs-battery ~~~~~~~~~~ Required properties : - - compatible : "sbs,sbs-battery" + - compatible: ",", "sbs,sbs-battery" as fallback. The + part number compatible string might be used in order to take care of + vendor specific registers. + Known ,: + ti,bq20z75 Optional properties : - sbs,i2c-retry-count : The number of times to retry i2c transactions on i2c @@ -14,9 +18,9 @@ Optional properties : Example: - bq20z75@b { - compatible = "sbs,sbs-battery"; - reg = < 0xb >; + battery@b { + compatible = "ti,bq20z75", "sbs,sbs-battery"; + reg = <0xb>; sbs,i2c-retry-count = <2>; sbs,poll-retry-count = <10>; sbs,battery-detect-gpios = <&gpio-controller 122 1>;