| Message ID | 20181016145651eucas1p1ea84684e37e67b4161548e6cff489cb8~eHqPK-tM31616816168eucas1p1y@eucas1p1.samsung.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
| Series | thermal: add new flag irq-mode for trip point | expand |
On Tue, 16 Oct 2018 at 16:56, Lukasz Luba <l.luba@partner.samsung.com> wrote: > > This patch adds support for new flash which indicates > that trip point triggers irq when temperature is met. > Exynos5433 supports 8 trip point which will trigger irq. Exynos5420? 4 trip points? BTW, I just noted that you skipped samsung-soc mailing list. DTS patches always should go through arm-soc so in case of Exynos - linux-samsung-soc mailing list. The list should be also CC-ed if you touch other Exynos or Samsung related code and get_maintainers.pl always point it. Because you skipped it, some people might miss your patches and definitely Patchwork which I am using won't see them (https://patchwork.kernel.org/project/linux-samsung-soc/list/). Best regards, Krzysztof
On 10/16/2018 05:13 PM, Krzysztof Kozlowski wrote: > On Tue, 16 Oct 2018 at 16:56, Lukasz Luba <l.luba@partner.samsung.com> wrote: >> >> This patch adds support for new flash which indicates >> that trip point triggers irq when temperature is met. >> Exynos5433 supports 8 trip point which will trigger irq. > > Exynos5420? 4 trip point Thanks, you are right. I will fix the comment in a few places. > > BTW, I just noted that you skipped samsung-soc mailing list. > > DTS patches always should go through arm-soc so in case of Exynos - > linux-samsung-soc mailing list. The list should be also CC-ed if you > touch other Exynos or Samsung related code and get_maintainers.pl > always point it. Because you skipped it, some people might miss your > patches and definitely Patchwork which I am using won't see them > (https://patchwork.kernel.org/project/linux-samsung-soc/list/). OK, I will push v2 through that list also. Regards, Lukasz > > Best regards, > Krzysztof > >
diff --git a/arch/arm/boot/dts/exynos5420-trip-points.dtsi b/arch/arm/boot/dts/exynos5420-trip-points.dtsi index a67a3807..9e16970 100644 --- a/arch/arm/boot/dts/exynos5420-trip-points.dtsi +++ b/arch/arm/boot/dts/exynos5420-trip-points.dtsi @@ -11,21 +11,25 @@ trips { cpu-alert-0 { temperature = <85000>; /* millicelsius */ hysteresis = <10000>; /* millicelsius */ - type = "active"; + type = "passive"; + irq-mode; }; cpu-alert-1 { temperature = <103000>; /* millicelsius */ hysteresis = <10000>; /* millicelsius */ - type = "active"; + type = "passive"; + irq-mode; }; cpu-alert-2 { temperature = <110000>; /* millicelsius */ hysteresis = <10000>; /* millicelsius */ - type = "active"; + type = "passive"; + irq-mode; }; cpu-crit-0 { temperature = <120000>; /* millicelsius */ hysteresis = <0>; /* millicelsius */ type = "critical"; + irq-mode; }; };
This patch adds support for new flash which indicates that trip point triggers irq when temperature is met. Exynos5433 supports 8 trip point which will trigger irq. Above that number other trip points should be registered without 'irq-mode' flag. That will force the thermal framework to start polling the temperature sensor under configured conditions and handle the trip point. Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> --- arch/arm/boot/dts/exynos5420-trip-points.dtsi | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)