| Message ID | 20181124143138.28999-1-tiny.windzz@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | power/reset: axxia: Convert to using %pOFn instead of device_node.name | expand |
On Sat, Nov 24, 2018 at 8:31 AM Yangtao Li <tiny.windzz@gmail.com> wrote: > > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/power/reset/axxia-reset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, but I already sent out the same patch and have queued it since no one picked it up. Rob > > diff --git a/drivers/power/reset/axxia-reset.c b/drivers/power/reset/axxia-reset.c > index 4e4cd1c8fe50..b16013265142 100644 > --- a/drivers/power/reset/axxia-reset.c > +++ b/drivers/power/reset/axxia-reset.c > @@ -65,7 +65,7 @@ static int axxia_reset_probe(struct platform_device *pdev) > > syscon = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon"); > if (IS_ERR(syscon)) { > - pr_err("%s: syscon lookup failed\n", dev->of_node->name); > + pr_err("%pOFn: syscon lookup failed\n", dev->of_node); > return PTR_ERR(syscon); > } > > -- > 2.17.0 >
Hi, On Tue, Nov 27, 2018 at 10:51:09AM -0600, Rob Herring wrote: > On Sat, Nov 24, 2018 at 8:31 AM Yangtao Li <tiny.windzz@gmail.com> wrote: > > > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/power/reset/axxia-reset.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks, but I already sent out the same patch and have queued it since > no one picked it up. Yeah, I did not find enough time to review patches in the last few weeks. OTOH I don't see a previous patch with axxia in the Subject in my mailbox anyways. FWIW I will skip this one. -- Sebastian > > Rob > > > > diff --git a/drivers/power/reset/axxia-reset.c b/drivers/power/reset/axxia-reset.c > > index 4e4cd1c8fe50..b16013265142 100644 > > --- a/drivers/power/reset/axxia-reset.c > > +++ b/drivers/power/reset/axxia-reset.c > > @@ -65,7 +65,7 @@ static int axxia_reset_probe(struct platform_device *pdev) > > > > syscon = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon"); > > if (IS_ERR(syscon)) { > > - pr_err("%s: syscon lookup failed\n", dev->of_node->name); > > + pr_err("%pOFn: syscon lookup failed\n", dev->of_node); > > return PTR_ERR(syscon); > > } > > > > -- > > 2.17.0 > >
diff --git a/drivers/power/reset/axxia-reset.c b/drivers/power/reset/axxia-reset.c index 4e4cd1c8fe50..b16013265142 100644 --- a/drivers/power/reset/axxia-reset.c +++ b/drivers/power/reset/axxia-reset.c @@ -65,7 +65,7 @@ static int axxia_reset_probe(struct platform_device *pdev) syscon = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon"); if (IS_ERR(syscon)) { - pr_err("%s: syscon lookup failed\n", dev->of_node->name); + pr_err("%pOFn: syscon lookup failed\n", dev->of_node); return PTR_ERR(syscon); }
In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/power/reset/axxia-reset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)