| Message ID | 20190415012635.6369-5-matheus@castello.eng.br (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | power: supply: MAX17040: Add IRQ for low level and alert SOC changes | expand |
On Mon, 15 Apr 2019 at 03:48, Matheus Castello <matheus@castello.eng.br> wrote: > > Notify core through power_supply_changed() in case of changes in state > of charge. This is useful for user-space to efficiently update current > battery level. > > Signed-off-by: Matheus Castello <matheus@castello.eng.br> > --- > drivers/power/supply/max17040_battery.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c > index f036f272d52f..db901ebf495d 100644 > --- a/drivers/power/supply/max17040_battery.c > +++ b/drivers/power/supply/max17040_battery.c > @@ -208,10 +208,17 @@ static void max17040_check_changes(struct i2c_client *client) > static void max17040_work(struct work_struct *work) > { > struct max17040_chip *chip; > + int last_soc; > > chip = container_of(work, struct max17040_chip, work.work); > + /* store SOC for check change */ > + last_soc = chip->soc; > max17040_check_changes(chip->client); > > + /* check changes and send uevent */ > + if (last_soc != chip->soc) chip->soc could be negative ERRNO so in such case I think user-space should not be notified. > + power_supply_changed(chip->battery); > + You should also notify on online and status change (e.g. started charging). User-space also wants to know that, e.g. to show the charging icon or battery health status. Best regards, Krzysztof
diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c index f036f272d52f..db901ebf495d 100644 --- a/drivers/power/supply/max17040_battery.c +++ b/drivers/power/supply/max17040_battery.c @@ -208,10 +208,17 @@ static void max17040_check_changes(struct i2c_client *client) static void max17040_work(struct work_struct *work) { struct max17040_chip *chip; + int last_soc; chip = container_of(work, struct max17040_chip, work.work); + /* store SOC for check change */ + last_soc = chip->soc; max17040_check_changes(chip->client); + /* check changes and send uevent */ + if (last_soc != chip->soc) + power_supply_changed(chip->battery); + queue_delayed_work(system_power_efficient_wq, &chip->work, MAX17040_DELAY); }
Notify core through power_supply_changed() in case of changes in state of charge. This is useful for user-space to efficiently update current battery level. Signed-off-by: Matheus Castello <matheus@castello.eng.br> --- drivers/power/supply/max17040_battery.c | 7 +++++++ 1 file changed, 7 insertions(+)