From patchwork Thu May 9 12:30:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 10937111 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1102D912 for ; Thu, 9 May 2019 12:31:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 020F828AD5 for ; Thu, 9 May 2019 12:31:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EAB6C28A16; Thu, 9 May 2019 12:31:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E2F028747 for ; Thu, 9 May 2019 12:31:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726690AbfEIMbN (ORCPT ); Thu, 9 May 2019 08:31:13 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:40343 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726426AbfEIMbN (ORCPT ); Thu, 9 May 2019 08:31:13 -0400 Received: by mail-pg1-f194.google.com with SMTP id d31so1151859pgl.7 for ; Thu, 09 May 2019 05:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6bX9fynWNx2rR1u6KZJt+Xl0Rl1d3gCgoD8/fabCDdY=; b=G9wQb2v5qZHTDZxakpQfPY6NRoW9Fd9LrSk7visuguj9rz2qA2wYh05F/MqSVEOS83 qdgvkqJ6fvRrESETA8qwSF7zCtiomXboyHiAoDZnOKew9z9jMU4E1ZXdrfj6pKjlXtnW 0/nKNCOIPSBA4PYrvHuxwnlWentEmhI0gcAmFUo3ipvJFzWrX25PQP3chdPfixOyo2FC fGlFjETsuLlS8fvNKjxzlXfO4clKs/zcvBl8ErfYNYLhlOlH2CxYtShw4IGWqTP51yMD kOs387vtA7nJDsRsOTUmnE2Qt1GyM9mZuFYIqgdGcBPDrA4FugBFyqPPsMukVwNtozuk l2jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6bX9fynWNx2rR1u6KZJt+Xl0Rl1d3gCgoD8/fabCDdY=; b=Oe3El8ynjTnZtP0wqyBM1KBBUczy5Z9wjZ/28KXDNrHIWmqT4ct1n4Z7JyAdwwI9+r H/t5JT9DI+t9shaD8DMt2i7Dxfz/wDJpPm7RoXN3LCrgTuWH3XfNWtSfRUS/YkqyqscC b0zTBEELpPSj+4CTC7bkLqoonzXi6shiXxD+sb3dEUcu1FQv304CBLXa7ZtM0XI0dKo3 G5iWg8dezpXG5OK4vqDzqMlHBCFtPlEch9859KwRFviNI2LDckuSHD65VZPT5/VRGQO9 j/nILR3sBdwUPRCO3wMib3ZIz6OnVc94P9d+CSMzggHTcE6KmlpvlTefTmj+mnJXy9Hx LCvA== X-Gm-Message-State: APjAAAVxryyRqVn51N0AtquMElgzc5Bkj14Ufh4Ah78q2605U1yEv3nK m+C6+Y7SbS6H6y3FTmB3rW9TTg== X-Google-Smtp-Source: APXvYqzrmZ3kQHepWnFt0I+6NQOsU7O09d0ut41LQbSocXDfWH3ni+fgsZrP3B7AZRVnOzHDf50XmA== X-Received: by 2002:a62:594b:: with SMTP id n72mr4685114pfb.186.1557405072101; Thu, 09 May 2019 05:31:12 -0700 (PDT) Received: from localhost.localdomain (220-133-186-239.HINET-IP.hinet.net. [220.133.186.239]) by smtp.gmail.com with ESMTPSA id o20sm1520000pgj.70.2019.05.09.05.31.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 05:31:11 -0700 (PDT) From: Axel Lin To: Andrey Smirnov Cc: Enric Balletbo Serra , Sebastian Reichel , linux-pm@vger.kernel.org, Axel Lin Subject: [PATCH] power: supply: ucs1002: Fix checking return value of devm_regmap_init_i2c Date: Thu, 9 May 2019 20:30:47 +0800 Message-Id: <20190509123047.27466-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Current code checks wrong return value, it should check info->regmap rather than info->charger. Fix it. Signed-off-by: Axel Lin --- drivers/power/supply/ucs1002_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/ucs1002_power.c b/drivers/power/supply/ucs1002_power.c index 33409b13232a..1c89d030c045 100644 --- a/drivers/power/supply/ucs1002_power.c +++ b/drivers/power/supply/ucs1002_power.c @@ -508,7 +508,7 @@ static int ucs1002_probe(struct i2c_client *client, return -ENOMEM; info->regmap = devm_regmap_init_i2c(client, ®map_config); - ret = PTR_ERR_OR_ZERO(info->charger); + ret = PTR_ERR_OR_ZERO(info->regmap); if (ret) { dev_err(dev, "Regmap initialization failed: %d\n", ret); return ret;