| Message ID | 20190605190053.19177-2-ezequiel@collabora.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/2] PM / devfreq: Fix governor module load failure | expand |
Hi, Frankly, I don't like the existing 'DEVFREQ: ' prefix because it is not used on all error log and it is not necessary. Instead of this patch, I just prefer to delete the 'DEVFREQ: ' prefix On 19. 6. 6. 오전 4:00, Ezequiel Garcia wrote: > This commit is a simple cosmetic cleanup, where pr_fmt is used to avoid > the "DEVFREQ" prefix in some prints. > > Also, messages are changed to not start with a capital. This is just > a cosmetic change, meant to sanitize all prints from this file. > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > --- > drivers/devfreq/devfreq.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index 8868ad9472d2..44392fa1c570 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -10,6 +10,8 @@ > * published by the Free Software Foundation. > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > #include <linux/kernel.h> > #include <linux/kmod.h> > #include <linux/sched.h> > @@ -59,7 +61,7 @@ static struct devfreq *find_device_devfreq(struct device *dev) > struct devfreq *tmp_devfreq; > > if (IS_ERR_OR_NULL(dev)) { > - pr_err("DEVFREQ: %s: Invalid parameters\n", __func__); > + pr_err("%s: invalid parameters\n", __func__); > return ERR_PTR(-EINVAL); > } > WARN(!mutex_is_locked(&devfreq_list_lock), > @@ -208,7 +210,7 @@ static struct devfreq_governor *find_devfreq_governor(const char *name) > struct devfreq_governor *tmp_governor; > > if (IS_ERR_OR_NULL(name)) { > - pr_err("DEVFREQ: %s: Invalid parameters\n", __func__); > + pr_err("%s: invalid parameters\n", __func__); > return ERR_PTR(-EINVAL); > } > WARN(!mutex_is_locked(&devfreq_list_lock), > @@ -238,7 +240,7 @@ static struct devfreq_governor *try_then_request_governor(const char *name) > struct devfreq_governor *governor; > > if (IS_ERR_OR_NULL(name)) { > - pr_err("DEVFREQ: %s: Invalid parameters\n", __func__); > + pr_err("%s: invalid parameters\n", __func__); > return ERR_PTR(-EINVAL); > } > WARN(!mutex_is_locked(&devfreq_list_lock), > @@ -1001,7 +1003,7 @@ int devfreq_add_governor(struct devfreq_governor *governor) > int err = 0; > > if (!governor) { > - pr_err("%s: Invalid parameters.\n", __func__); > + pr_err("%s: invalid parameters.\n", __func__); > return -EINVAL; > } > > @@ -1066,7 +1068,7 @@ int devfreq_remove_governor(struct devfreq_governor *governor) > int err = 0; > > if (!governor) { > - pr_err("%s: Invalid parameters.\n", __func__); > + pr_err("%s: invalid parameters.\n", __func__); > return -EINVAL; > } > >
On Thu, 2019-06-20 at 16:23 +0900, Chanwoo Choi wrote: > Hi, > > Frankly, I don't like the existing 'DEVFREQ: ' prefix > because it is not used on all error log and it is not necessary. > > Instead of this patch, I just prefer to delete the 'DEVFREQ: ' prefix > Hm, I have to disagree. Having naked pr_{} with just the __func__ reducess logging consistency. Thanks, Ezequiel
Hi, On 19. 6. 20. 오후 11:41, Ezequiel Garcia wrote: > On Thu, 2019-06-20 at 16:23 +0900, Chanwoo Choi wrote: >> Hi, >> >> Frankly, I don't like the existing 'DEVFREQ: ' prefix >> because it is not used on all error log and it is not necessary. >> >> Instead of this patch, I just prefer to delete the 'DEVFREQ: ' prefix >> > > Hm, I have to disagree. Having naked pr_{} with just the __func__ > reducess logging consistency. Actually, it is minor clean-up and there are no any benefits. As I said, 'DEVFREQ: ' prefix was not used on all devfreq log. If you don't agree to remove 'DEVFREQ: ', no problem. IMO, just better to keep the current style without any addition changes.
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 8868ad9472d2..44392fa1c570 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -10,6 +10,8 @@ * published by the Free Software Foundation. */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include <linux/kernel.h> #include <linux/kmod.h> #include <linux/sched.h> @@ -59,7 +61,7 @@ static struct devfreq *find_device_devfreq(struct device *dev) struct devfreq *tmp_devfreq; if (IS_ERR_OR_NULL(dev)) { - pr_err("DEVFREQ: %s: Invalid parameters\n", __func__); + pr_err("%s: invalid parameters\n", __func__); return ERR_PTR(-EINVAL); } WARN(!mutex_is_locked(&devfreq_list_lock), @@ -208,7 +210,7 @@ static struct devfreq_governor *find_devfreq_governor(const char *name) struct devfreq_governor *tmp_governor; if (IS_ERR_OR_NULL(name)) { - pr_err("DEVFREQ: %s: Invalid parameters\n", __func__); + pr_err("%s: invalid parameters\n", __func__); return ERR_PTR(-EINVAL); } WARN(!mutex_is_locked(&devfreq_list_lock), @@ -238,7 +240,7 @@ static struct devfreq_governor *try_then_request_governor(const char *name) struct devfreq_governor *governor; if (IS_ERR_OR_NULL(name)) { - pr_err("DEVFREQ: %s: Invalid parameters\n", __func__); + pr_err("%s: invalid parameters\n", __func__); return ERR_PTR(-EINVAL); } WARN(!mutex_is_locked(&devfreq_list_lock), @@ -1001,7 +1003,7 @@ int devfreq_add_governor(struct devfreq_governor *governor) int err = 0; if (!governor) { - pr_err("%s: Invalid parameters.\n", __func__); + pr_err("%s: invalid parameters.\n", __func__); return -EINVAL; } @@ -1066,7 +1068,7 @@ int devfreq_remove_governor(struct devfreq_governor *governor) int err = 0; if (!governor) { - pr_err("%s: Invalid parameters.\n", __func__); + pr_err("%s: invalid parameters.\n", __func__); return -EINVAL; }
This commit is a simple cosmetic cleanup, where pr_fmt is used to avoid the "DEVFREQ" prefix in some prints. Also, messages are changed to not start with a capital. This is just a cosmetic change, meant to sanitize all prints from this file. Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> --- drivers/devfreq/devfreq.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)