From patchwork Thu Jun 27 21:10:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 11020717 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 37CE113B4 for ; Thu, 27 Jun 2019 21:14:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 304F128385 for ; Thu, 27 Jun 2019 21:14:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 24ECA2872E; Thu, 27 Jun 2019 21:14:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B385F28405 for ; Thu, 27 Jun 2019 21:14:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbfF0VM2 (ORCPT ); Thu, 27 Jun 2019 17:12:28 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:43927 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbfF0VM1 (ORCPT ); Thu, 27 Jun 2019 17:12:27 -0400 Received: by mail-lj1-f194.google.com with SMTP id 16so3775418ljv.10; Thu, 27 Jun 2019 14:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=12VJs13OPjF9DGDUp85PAmf8xnTp6sUbGcgLhNyWjKk=; b=J735c5q6XCcWq/wBeoa+K9ELgOTwtM1t+MGpI3UlCOToqIWBiwQ+AsYc2KZrEOxMrB y2iDjLSR7kLn9XM58fHfuqzH+qhy38Zoo5EG81WaZOAkhXZiF+jsGMp/oE6VpfGG50MN QDZ8QirP5XBXFes2Q8yc+jwMuEpo/+VnNcg8D+bDlKMAYw5IjA2pNIEKzYMdL6znI/bm SZmiNBgmf09DsIBDXEWZSJTEIZJ+yVURqKWCUOgGup1nrs2zCLkY+H2iNLW6DLW8gK1O PO5ksXGQuJPZy9sAMHCFYQ2M8ul1TlXA7mu8N0Rimp1vRWPK/2W00oDIXWZHWxO4BdNV +EPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=12VJs13OPjF9DGDUp85PAmf8xnTp6sUbGcgLhNyWjKk=; b=Ro0wMSOL4u1KeukL2OKmrej4lyNkzCPtxcrRCXNsUC5vakhQtlOij6I2NFiQd9I4WU Y/eLLW8G9nWFECx0ZZ8ELuKmBVSx8ocEsXxOdqJWKnNiFkmhAnfZK55exbXRRDciU/UW gbe3DkrS2yDgq0H/BQWeThexZQ7ESUVIKQ8SG8Jp68E5ZVXGGvDU9w/BIVNvN9f7s+81 L/A8cXN4WpTObfTfLF1Tes3Eg5jFuuiZyInCgtFD2t+srfQtHSz3E7tK4UVtaVX2T+nK DwLwkooTYmH2QEYByOXLX4dgCyRW5Bfr05NjMbsTMS7R64BNTfiBNSJBKp84KHZ/6f+g O70Q== X-Gm-Message-State: APjAAAXM4kK4+qlSE8rCq6lZeI9vggma4sQM5m2vT3iTNykZ53YU8fBA tTXx97MkgbgbWKPcLuJdeAt/HMLy X-Google-Smtp-Source: APXvYqxyaYSTlLELKw9QcoVq+BuNwm3g5TZHkIw5/Dsh1GceVaaQi5LL2EaqQAFhHgz2YC8iR5AOqg== X-Received: by 2002:a2e:9a19:: with SMTP id o25mr4048763lji.63.1561669945700; Thu, 27 Jun 2019 14:12:25 -0700 (PDT) Received: from localhost.localdomain (ppp91-79-162-197.pppoe.mtu-net.ru. [91.79.162.197]) by smtp.gmail.com with ESMTPSA id p29sm30485ljp.87.2019.06.27.14.12.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 14:12:24 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jonathan Hunter , Tomeu Vizoso Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 02/22] PM / devfreq: tegra30: Keep interrupt disabled while governor is stopped Date: Fri, 28 Jun 2019 00:10:55 +0300 Message-Id: <20190627211115.21138-3-digetx@gmail.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190627211115.21138-1-digetx@gmail.com> References: <20190627211115.21138-1-digetx@gmail.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no real need to keep interrupt always-enabled, will be nicer to keep it disabled while governor is inactive. Suggested-by: Thierry Reding Signed-off-by: Dmitry Osipenko --- drivers/devfreq/tegra30-devfreq.c | 43 ++++++++++++++++--------------- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index a27300f40b0b..5e2b133babdd 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -416,8 +417,6 @@ static void tegra_actmon_start(struct tegra_devfreq *tegra) { unsigned int i; - disable_irq(tegra->irq); - actmon_writel(tegra, ACTMON_SAMPLING_PERIOD - 1, ACTMON_GLB_PERIOD_CTRL); @@ -442,8 +441,6 @@ static void tegra_actmon_stop(struct tegra_devfreq *tegra) } actmon_write_barrier(tegra); - - enable_irq(tegra->irq); } static int tegra_devfreq_target(struct device *dev, unsigned long *freq, @@ -552,6 +549,12 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, { struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent); + /* + * Couple device with the governor early as it is needed at + * the moment of governor's start (used by ISR). + */ + tegra->devfreq = devfreq; + switch (event) { case DEVFREQ_GOV_START: devfreq_monitor_start(devfreq); @@ -586,10 +589,11 @@ static struct devfreq_governor tegra_devfreq_governor = { static int tegra_devfreq_probe(struct platform_device *pdev) { - struct tegra_devfreq *tegra; struct tegra_devfreq_device *dev; - unsigned int i; + struct tegra_devfreq *tegra; + struct devfreq *devfreq; unsigned long rate; + unsigned int i; int err; tegra = devm_kzalloc(&pdev->dev, sizeof(*tegra), GFP_KERNEL); @@ -625,6 +629,16 @@ static int tegra_devfreq_probe(struct platform_device *pdev) } tegra->irq = err; + irq_set_status_flags(tegra->irq, IRQ_NOAUTOEN); + + err = devm_request_threaded_irq(&pdev->dev, tegra->irq, NULL, + actmon_thread_isr, IRQF_ONESHOT, + "tegra-devfreq", tegra); + if (err) { + dev_err(&pdev->dev, "Interrupt request failed: %d\n", err); + return err; + } + reset_control_assert(tegra->reset); err = clk_prepare_enable(tegra->clock); @@ -672,28 +686,15 @@ static int tegra_devfreq_probe(struct platform_device *pdev) } tegra_devfreq_profile.initial_freq = clk_get_rate(tegra->emc_clock); - tegra->devfreq = devfreq_add_device(&pdev->dev, - &tegra_devfreq_profile, - "tegra_actmon", - NULL); + devfreq = devfreq_add_device(&pdev->dev, &tegra_devfreq_profile, + "tegra_actmon", NULL); if (IS_ERR(tegra->devfreq)) { err = PTR_ERR(tegra->devfreq); goto remove_governor; } - err = devm_request_threaded_irq(&pdev->dev, tegra->irq, NULL, - actmon_thread_isr, IRQF_ONESHOT, - "tegra-devfreq", tegra); - if (err) { - dev_err(&pdev->dev, "Interrupt request failed: %d\n", err); - goto remove_devfreq; - } - return 0; -remove_devfreq: - devfreq_remove_device(tegra->devfreq); - remove_governor: devfreq_remove_governor(&tegra_devfreq_governor);